Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp898333ybe; Thu, 5 Sep 2019 07:32:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqxHTdBnYlJ0CtNbv0FW48Bob51V5h1EdqkJmWQhCBs6Vz6pSTzPe1BzVOw7d5TgW6xLtp9C X-Received: by 2002:a17:902:8f90:: with SMTP id z16mr3755537plo.138.1567693952341; Thu, 05 Sep 2019 07:32:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567693952; cv=none; d=google.com; s=arc-20160816; b=IAc2K25ZNYNnAcvNUTsK9uczssFqGoXjFBNrhEDTS6910ckCQSbdFR4xoUATI3BpP0 gIIDi6rEoOLO+CZk3mTApRFH0nOINIvhWlc5gG4m6KyBFnB59fpVZPoztzCv0JF9JCH0 svpqj3eAnpMmRkNJtxm7PhZmbWOuK/S3kgCuyL1/4KgYoI4EXg28MtxGzytP2MXnA9iE aC3Qk5qvXUK2TfE0qWiLtFNPGqDlPgwFitf9ZEGkil9uh6GAjsRF3PpLK5GMuuyqWtrB LBs/vGmqr9VKlF43rsBQQ9OVes2m0eSYc6yT4kJkcrFBHltWSgPrLp/EI6roNyih4LcM TfNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=GX5C0h1u8/IyRqkJVkNXee+rrtlIJ6NnlLWkZW4o4VM=; b=Bwbb4rDyZduznBffHTY7Oyd/SRxVdA2kNP46wreo+jzYLU1F1wfr7J68qcr9yKYKQ6 ub+BEynnGoKeNl3i5DXnGccvB4KZr5nK+/DLRWPzmLw7qad6DogfyRObnPz9JpPvCzJf ckK6gG8wzY4uuFwC5zPdFP3hwap37w1H0goRta1pVQEw59YLvbj1obefPzV2mU6VD46S FkFyUPo9ah+wUJeOVHh78IScXwp04A71Q4WS4tbugJKE7oWFCDVudSCw8caozQmtT5TM Fv8qUKYDggnC/4pF7LFEvbt+dYN/vo7h3rrJE8kKb29fR5ztJGWrhei1Y/kqBWUaUlUQ PsrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si2150120pjn.2.2019.09.05.07.32.14; Thu, 05 Sep 2019 07:32:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388244AbfIEOUN (ORCPT + 99 others); Thu, 5 Sep 2019 10:20:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:47510 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725290AbfIEOUN (ORCPT ); Thu, 5 Sep 2019 10:20:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A5554AF92; Thu, 5 Sep 2019 14:20:11 +0000 (UTC) Date: Thu, 5 Sep 2019 16:20:10 +0200 From: Michal Hocko To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Tim Murray , carmenjackson@google.com, mayankgupta@google.com, dancol@google.com, rostedt@goodmis.org, minchan@kernel.org, akpm@linux-foundation.org, kernel-team@android.com, "Aneesh Kumar K.V" , Dan Williams , Jerome Glisse , linux-mm@kvack.org, Matthew Wilcox , Ralph Campbell , Vlastimil Babka Subject: Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold Message-ID: <20190905142010.GC3838@dhcp22.suse.cz> References: <20190903200905.198642-1-joel@joelfernandes.org> <20190904084508.GL3838@dhcp22.suse.cz> <20190904153258.GH240514@google.com> <20190904153759.GC3838@dhcp22.suse.cz> <20190904162808.GO240514@google.com> <20190905105424.GG3838@dhcp22.suse.cz> <20190905141452.GA26466@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905141452.GA26466@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 05-09-19 10:14:52, Joel Fernandes wrote: > On Thu, Sep 05, 2019 at 12:54:24PM +0200, Michal Hocko wrote: > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > > > > > On Wed, Sep 04, 2019 at 10:45:08AM +0200, Michal Hocko wrote: > > > > > > On Tue 03-09-19 16:09:05, Joel Fernandes (Google) wrote: > > > > > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > > > > > > memory hogs. Several Android teams have been using this patch in various > > > > > > > kernel trees for half a year now. Many reported to me it is really > > > > > > > useful so I'm posting it upstream. > > > > > > > > > > > > > > Initial patch developed by Tim Murray. Changes I made from original patch: > > > > > > > o Prevent any additional space consumed by mm_struct. > > > > > > > o Keep overhead low by checking if tracing is enabled. > > > > > > > o Add some noise reduction and lower overhead by emitting only on > > > > > > > threshold changes. > > > > > > > > > > > > Does this have any pre-requisite? I do not see trace_rss_stat_enabled in > > > > > > the Linus tree (nor in linux-next). > > > > > > > > > > No, this is generated automatically by the tracepoint infrastructure when a > > > > > tracepoint is added. > > > > > > > > OK, I was not aware of that. > > > > > > > > > > Besides that why do we need batching in the first place. Does this have a > > > > > > measurable overhead? How does it differ from any other tracepoints that we > > > > > > have in other hotpaths (e.g. page allocator doesn't do any checks). > > > > > > > > > > We do need batching not only for overhead reduction, > > > > > > > > What is the overhead? > > > > > > The overhead is occasionally higher without the threshold (that is if we > > > trace every counter change). I would classify performance benefit to be > > > almost the same and within the noise. > > > > OK, so the additional code is not really justified. > > It is really justified. Did you read the whole of the last email? Of course I have. The information that numbers are in noise with some outliers (without any details about the underlying reason) is simply showing that you are optimizing something probably not worth it. I would recommend adding a simple tracepoint. That should be pretty non controversial. And if you want to add an optimization on top then provide data to justify it. -- Michal Hocko SUSE Labs