Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp920195ybe; Thu, 5 Sep 2019 07:51:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwDYo4o821rikYdnqrJpAPwYnSPaQ0vrDM8Q3+C7z2/fgBvc7BCm/GBcpsOuCh7B6ZAL7n2 X-Received: by 2002:a17:90a:234d:: with SMTP id f71mr4234010pje.125.1567695075342; Thu, 05 Sep 2019 07:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567695075; cv=none; d=google.com; s=arc-20160816; b=n4k+0agi7DlZWwZjOOP/yd+bz+pVnXyBcs0PHE+tG31RlaVWqtwcKPRvq7ub8RbVt6 mkYYbpGlE3gTuQ9vsK90hTGOfRl/kYFdrIpf4uXzD5lkac0MTRkx4oL3JyfBhcNo/Xvl LATm1Ap9GH6qTi11OsD6cO7UI5UFerwM7HRrJQxb0uxJvqy2jraecQsgTMgL0iR1Ppe9 jnjI+w7LKZTs0ER0JBgHnEHBOoM+F79BIPm05OEWC/7nZ0kawwUYw/Yomo8+t5r2bdL8 L7LukE9xeUCa9UjXQVBZA7yNR2eI6mKRxjrU1z7g3dPHlaJm3MDBkGwe3JzgkuYVbxhl VNRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=9opop7h3fUkRLrhS3Knix18nk9kyv5Ud+q/jqkZpmF8=; b=HNwq/drUCgoWI9XfUo9OvX6vCSf2dQNnZUyQvVQ20hCINTAwOvKLWcbin2VYVOvT/f 0zwStOqNvukfrmpe5HwQ2xmVYCDV3fDEuoS5/BnWa/vTrzmxxGu82kzkOVsO7Vfivopv 9IBza5sqZhVP1tJ1+rNnNfx4mEbArEGqtSHPbQuKp38SAvScogpxp5v5wSia754zbavI AUpa2qOANlIC03STifiQXDlyS+kgxPZRqcdCGzDZF3iJyCEYoFV4wj9WlA5aXGorb3YF nP+s09T8/YJ9LwGu3G6T03l5ZbDIoxCMcIVkfJs2/954RSgaolZ9vnjNPJ999Y9xQ7CM A+KA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7si2234548pjn.50.2019.09.05.07.50.57; Thu, 05 Sep 2019 07:51:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390067AbfIEOtB (ORCPT + 99 others); Thu, 5 Sep 2019 10:49:01 -0400 Received: from foss.arm.com ([217.140.110.172]:46386 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389853AbfIEOtA (ORCPT ); Thu, 5 Sep 2019 10:49:00 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C718D28; Thu, 5 Sep 2019 07:48:59 -0700 (PDT) Received: from [10.1.194.37] (e113632-lin.cambridge.arm.com [10.1.194.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EDE93F67D; Thu, 5 Sep 2019 07:48:58 -0700 (PDT) Subject: Re: [RFC PATCH 1/9] sched,cgroup: Add interface for latency-nice To: Patrick Bellasi Cc: Peter Zijlstra , Subhra Mazumdar , linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, steven.sistare@oracle.com, dhaval.giani@oracle.com, daniel.lezcano@linaro.org, vincent.guittot@linaro.org, viresh.kumar@linaro.org, tim.c.chen@linux.intel.com, mgorman@techsingularity.net, parth@linux.ibm.com References: <20190830174944.21741-1-subhra.mazumdar@oracle.com> <20190830174944.21741-2-subhra.mazumdar@oracle.com> <20190905083127.GA2332@hirez.programming.kicks-ass.net> <87r24v2i14.fsf@arm.com> <20190905104616.GD2332@hirez.programming.kicks-ass.net> <87imq72dpc.fsf@arm.com> <87d0ge3n85.fsf@arm.com> From: Valentin Schneider Message-ID: <3d3306e4-3a78-5322-df69-7665cf01cc43@arm.com> Date: Thu, 5 Sep 2019 15:48:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87d0ge3n85.fsf@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2019 14:07, Patrick Bellasi wrote: > Yep, I think so fare we are all converging towards the idea to use the > a signed range. Regarding the range itself, yes: 1024 looks very > oversized, but +-20 is still something which leave room for a bit of > flexibility and it also better matches the idea that we don't want to > "enumerate behaviours" but just expose a knob. To map certain "bias" we > could benefit from a slightly larger range. > >> AFAICT this RFC only looks at wakeups, but I guess latency-nice can be > > For the wakeup path there is also the TurboSched proposal by Parth: > > Message-ID: <20190725070857.6639-1-parth@linux.ibm.com> > https://lore.kernel.org/lkml/20190725070857.6639-1-parth@linux.ibm.com/ > > we should keep in mind. > >> applied elsewhere (e.g. load-balance, something like task_hot() and its >> use of sysctl_sched_migration_cost). > > For LB can you come up with some better description of what usages you > see could benefit from a "per task" or "per task-group" latency niceness? > task_hot() "ratelimits" migrations of tasks that were running up until very recently (hence "cache hot"), but the knob is system wide. It might make sense to exploit a per-task attribute to tune this (e.g. go wild if not latency sensitive, otherwise stay away for longer). We could perhaps even apply it to active load balance to similarly stay away from latency sensitive tasks. Right now this is gated by a sched_domain-wide attribute (nr_balance_failed). We could tweak this to requiring more (less) failed attempts before interrupting latency (in) sensitive tasks. I'm sure we can come up with even more creative ways to pour even more heuristics in there ;) > Best, > Patrick >