Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp989446ybe; Thu, 5 Sep 2019 08:45:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwoCULiKz+3DqDryP2ifogx8y7wEj6elG63/KIoRivr0x7xowRCdL55vf/bIrujZGmDcSg X-Received: by 2002:a17:902:61:: with SMTP id 88mr4148575pla.111.1567698355905; Thu, 05 Sep 2019 08:45:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567698355; cv=none; d=google.com; s=arc-20160816; b=QfWS7OBNxqHdIHyqV2WQCVO1gzj0faEmK49QbrqcyW6DVvbnQYrBPxSgD+6pycpZKA Q6StjLfGBzTWuxvPWxHOo5I+5g/OSUbYvfYyQYaQH0U3JRVrS997Hh83B5BMbizb9lZQ YkHVXRXO1J1SLjK3q1OUTHNA7F4UAJ6E8ARshs89zN3mckUQ0/9JacOyWv1dIesKIZBm HjIEr9VubbcWoZ6bIN81y05htSY0oClgeXoURWAZiAXF4c9x3SSfHVSwCtY6EBjE5YML iD2SaiG9og4w73kdUqNSJ7PMgV72fH4znj70TuI7avdHIRROInVA8EOftBeRqYFPYyTY hl+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AwgA7SrA9F+LhiSKrLER8oP0ITNy6ixrzpUedPtR18k=; b=L7Dk6Lqfk20m3frLrWUeZ8HHl5EWvf+Qp8WO/hx0t2Di6tkNePsLki5e7S4GAG9ft0 maKAsg7rFpi+tKmmRfB1IBvfCS9AIy3SFAjaeULbHsnf/SjfgydOj77qXOOc7lUrwLTR YFczKCicHH3J+TF9UHHolcCyDey67rtevC+Q+P26H2sAPJq9qRqVv/qVZF+Tv1Se+EH6 Y2ZoWGpwLKXU8U4rxdx/2IY9bBXHnj7r8jJLclc/n09kfS1WPXOMU7l0eOooVM65AkmF zz4JtVXXHUFCT3xQQtxzVE8Ik37CLrutptVFlzr5N+0dNK/1JiFwYZeMqoop2Z5wv4kN NrgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si2133137pgr.555.2019.09.05.08.45.39; Thu, 05 Sep 2019 08:45:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389151AbfIEMDo (ORCPT + 99 others); Thu, 5 Sep 2019 08:03:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55679 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389060AbfIEMDW (ORCPT ); Thu, 5 Sep 2019 08:03:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6671AC057EC0; Thu, 5 Sep 2019 12:03:22 +0000 (UTC) Received: from prarit.bos.redhat.com (prarit-guest.khw1.lab.eng.bos.redhat.com [10.16.200.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3FA31001947; Thu, 5 Sep 2019 12:03:21 +0000 (UTC) From: Prarit Bhargava To: platform-driver-x86@vger.kernel.org Cc: andriy.shevchenko@intel.com, Prarit Bhargava , Srinivas Pandruvada , David Arcari , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/9] tools/power/x86/intel-speed-select: Fix cpu-count output Date: Thu, 5 Sep 2019 08:03:05 -0400 Message-Id: <20190905120311.15286-4-prarit@redhat.com> In-Reply-To: <20190905120311.15286-1-prarit@redhat.com> References: <20190905120311.15286-1-prarit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 05 Sep 2019 12:03:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have a system with 28 threads/socket but intel-speed-select reports a cpu-count of 29. Fix an off-by-one error in the cpu_count() function. Signed-off-by: Prarit Bhargava Cc: Srinivas Pandruvada Cc: David Arcari Cc: linux-kernel@vger.kernel.org --- tools/power/x86/intel-speed-select/isst-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c index d32af8210427..f81a28c6b586 100644 --- a/tools/power/x86/intel-speed-select/isst-config.c +++ b/tools/power/x86/intel-speed-select/isst-config.c @@ -304,7 +304,7 @@ static void set_cpu_present_cpu_mask(void) int get_cpu_count(int pkg_id, int die_id) { if (pkg_id < MAX_PACKAGE_COUNT && die_id < MAX_DIE_PER_PACKAGE) - return cpu_cnt[pkg_id][die_id] + 1; + return cpu_cnt[pkg_id][die_id]; return 0; } -- 2.21.0