Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1035353ybe; Thu, 5 Sep 2019 09:20:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqy48XKxfaTHrQTZjBD36bJ8hi6qJWafkY+f1waZnOG6+NVKmXKCs7zlBWWhqWxPvsnSHSKI X-Received: by 2002:a17:90a:c386:: with SMTP id h6mr4739617pjt.122.1567700435874; Thu, 05 Sep 2019 09:20:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567700435; cv=none; d=google.com; s=arc-20160816; b=IG0bD/NT1ETKrIaH4VmiCghcxJ1k75BGMhX61S3l+naP8zHmPwiPDqmKXwZB0v8t+r 0LhSetxpcLVCOv/Cy67gF7F2eWFErsjlKN4/xX+ea76hS3lj6xPFIfs71WTzrLhGNtJJ hcmhnPkZX83xvVKgVTXQnlTlUXrYXpzLetvLrQBraYjZi0JI1ooyS+SeJ1USboIjVFac 7aJCkaVtv5TJA1bi3m+xBhnV/imA2snRopDZZrck2RsO2u5ByW07K/dQBEP2n4A0bVpe 3W6qKXaWCx8hDwISw+dcBpANE/QhcvCXay2sG/cdnmO4bxaEsY5bZyck2nd2utYt5/Z6 goyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=mOTha34gu7LiNjrKRb5+XMuiqCCl6REbYMmzCsT4pk0=; b=cqrQKuQ/lyRCFN81gZ5e+RQ7UYKQJDLSI9/7WT3EYozlyo9qYAVEF+i3Yl80YtmGmQ tmBVervr9CFUnp8kWZ8YNXTe/3hAaGT5xg4EGI9Kzzc0dHxhAO3SOOSG40NJ6c5JAHL7 m9M2V1kVgk2HVrojh9RoXB0DzBgV753K8nlniRJp/R7qRRt6IoE/nHSzmCqU7r5Q7bA0 oDgdpCOeS0rsZ2TPwBpB0eHuvSlzJYkLF8C/qLHqXYJJkMI/j7Agt+MT3HiwFXM8Oha/ cgCxFovbKuknpj0f+Asmk4WOQ4FKgC4VcEfX4gdiDoZvfchP7sGQG58nfRT0n7WFqD1N JWbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=mZoYWvbb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si2157544pgu.98.2019.09.05.09.20.19; Thu, 05 Sep 2019 09:20:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=mZoYWvbb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733242AbfIEOAp (ORCPT + 99 others); Thu, 5 Sep 2019 10:00:45 -0400 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:38982 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbfIEOAp (ORCPT ); Thu, 5 Sep 2019 10:00:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1567692045; x=1599228045; h=from:to:cc:subject:date:message-id:mime-version; bh=mOTha34gu7LiNjrKRb5+XMuiqCCl6REbYMmzCsT4pk0=; b=mZoYWvbbbuWJjUthitgqqn/CPhKaIQk4nZoEWKX8tpmx7DCm0pHTc/Cp /n6VaN+OD8mF7wZcnfdb/LHwc28SY1ogxtSO9QoUm34/8jC9x6OUSfT5U rcr4vm5NDr41wIsr+Mero4/FOmU1j4nx+ZfWkugGA2djQB78R94doAYD1 I=; X-IronPort-AV: E=Sophos;i="5.64,470,1559520000"; d="scan'208";a="827733109" Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-1e-97fdccfd.us-east-1.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 05 Sep 2019 14:00:42 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-97fdccfd.us-east-1.amazon.com (Postfix) with ESMTPS id A241CA1E4C; Thu, 5 Sep 2019 14:00:38 +0000 (UTC) Received: from EX13D13UWA001.ant.amazon.com (10.43.160.136) by EX13MTAUWA001.ant.amazon.com (10.43.160.58) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 5 Sep 2019 14:00:38 +0000 Received: from u9ff250417f405e.ant.amazon.com (10.43.160.20) by EX13D13UWA001.ant.amazon.com (10.43.160.136) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 5 Sep 2019 14:00:31 +0000 From: Jonathan Chocron To: , , , , , CC: , , , , , , , , , , , , Subject: [PATCH v5 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver Date: Thu, 5 Sep 2019 17:00:14 +0300 Message-ID: <20190905140018.5139-1-jonnyc@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.160.20] X-ClientProxiedBy: EX13D06UWA002.ant.amazon.com (10.43.160.143) To EX13D13UWA001.ant.amazon.com (10.43.160.136) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series adds support for Amazon's Annapurna Labs DT-based PCIe host controller driver. Additionally, it adds 3 quirks (ACS, VPD and MSI-X) and 2 generic DWC patches. Changes since v4: - Moved the HEADER_TYPE validations to after pp->ops->host_init() and ep->ops->ep_init() - Changed to dw_pcie_rd_own_conf() instead of dw_pcie_readb_dbi() for reading the HEADER_TYPE - Used exsitng quirk_blacklist_vpd() instead of quirk_al_vpd_release() - Added a newline in ACS quirk comment Changes since v3: - Removed PATCH 8/8 since the usage of the PCI flags will be discussed in the upcoming LPC - Align commit subject with the folder convention - Added explanation regarding ECAM "overload" mechanism - Switched to read/write{_relaxed} APIs - Modified a dev_err to dev_dbg - Removed unnecessary variable - Removed driver details from dt-binding description - Changed to SoC specific compatibles - Fixed typo in a commit message - Added comment regarding MSI in the MSI-X quirk Changes since v2: - Added al_pcie_controller_readl/writel() wrappers - Reorganized local vars in several functions according to reverse tree structure - Removed unnecessary check of ret value - Changed return type of al_pcie_config_prepare() from int to void - Removed check if link is up from probe() [done internally in dw_pcie_rd/wr_conf()] Changes since v1: - Added comment regarding 0x0031 being used as a dev_id for non root-port devices as well - Fixed different message/comment/print wordings - Added panic stacktrace to commit message of MSI-x quirk patch - Changed to pci_warn() instead of dev_warn() - Added unit_address after node_name in dt-binding - Updated Kconfig help description - Used GENMASK and FIELD_PREP/GET where appropriate - Removed leftover field from struct al_pcie and moved all ptrs to the beginning - Re-wrapped function definitions and invocations to use fewer lines - Change %p to %px in dbg prints in rd/wr_conf() functions - Removed validation that the port is configured to RC mode (as this is added generically in PATCH 7/8) - Removed unnecessary variable initializations - Swtiched to %pR for printing resources Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron (6): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Prevent VPD access for Amazon's Annapurna Labs Root Port PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding PCI: dwc: al: Add support for DW based driver type PCI: dwc: Add validation that PCIe core is set to correct mode .../devicetree/bindings/pci/pcie-al.txt | 46 +++ MAINTAINERS | 3 +- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 365 ++++++++++++++++++ .../pci/controller/dwc/pcie-designware-ep.c | 8 + .../pci/controller/dwc/pcie-designware-host.c | 16 + drivers/pci/quirks.c | 38 ++ drivers/pci/vpd.c | 6 + include/linux/pci_ids.h | 2 + 9 files changed, 495 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/pci/pcie-al.txt -- 2.17.1