Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1043548ybe; Thu, 5 Sep 2019 09:27:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhbLFn/Vm/hwiiRfEd2BPfXVkcgQycjdE5PrE5/hIoeNbj9kkpsuyPkaGeALP9lMsuTUxU X-Received: by 2002:a17:90a:264a:: with SMTP id l68mr4926743pje.74.1567700840173; Thu, 05 Sep 2019 09:27:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567700840; cv=none; d=google.com; s=arc-20160816; b=H57TjZW5/6j92gFiWt84tPNRQ4eaGYWXmr3uEtpgO/p8X9EGPTZtCMC+7Mo/GIt0gO 90H05jyGiEwkbYPsWM1NV8ysPNCLgG6iMcdYWp358HhWiwJZ01hn8OZGjw1LBAKx5TQK ZV64n5+Y/SSKuO8b6xkss5AQR2FxHti/YeVbHTrkzQ9WBkLAfXM/XnK/WWBM55a9vTKM fxbV0bSI3ubAMhtn6beE9vxUn30+GBJe7TByU3mKu+MFVFlIe+YlJp7859p5W5BGxodq PDsaHPL8JnHlzU9xroOZKkMtYHZ5TCflrSZw53Yt92qusi8slAFa9sRjJvTNir/2PM0O lpsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zXRGEZPwLtQ5UinxPXKU5BfJwpOCdWN4x79WEBjhqjE=; b=oljGmkn/uTFyGRhMm0pxBtm+npk7WC5k6iR1H/VCnxKAV1/wWGIKKN8gbnhkZBz8A2 ql+g38/GpliKNaFLvXHwGq24iVF02AgTYn8Bf4YP8RiyyIUtRzhWD3KuQ1G4NP6m5YVF tBof5CR/DpDjW0FPXgJ3GwVPQqyhhn367nNdoBVTtKRbANAizL5cFdOLJFcS4awonmq/ Vq8xP50/PtM/ceJ2L+Yb6So6AlDfP/SlZ6H0AUAVxEuSYZjwF4kaXWv8XsV/IvcS6r3x g3ozglgehZ8n8c8Clgfe7u+30D57GtQj1+XE1jBE7i42WKmflmwdoCoxWkIBRwqcgILC GT1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=MBtV92rB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gb1si2400974plb.259.2019.09.05.09.27.03; Thu, 05 Sep 2019 09:27:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=MBtV92rB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389921AbfIEOrB (ORCPT + 99 others); Thu, 5 Sep 2019 10:47:01 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:39791 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389424AbfIEOrB (ORCPT ); Thu, 5 Sep 2019 10:47:01 -0400 Received: by mail-wm1-f66.google.com with SMTP id q12so3405262wmj.4 for ; Thu, 05 Sep 2019 07:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zXRGEZPwLtQ5UinxPXKU5BfJwpOCdWN4x79WEBjhqjE=; b=MBtV92rBa45246haRPT8qJPcyhwAnCzGKWvtch+yphLIQemMY/gh8rghP/zBtzfhZM cpNvyMRnAG5QKZHMWcZ9nGFEPxpgrPHlGg7/XLUNNd4u6wM+0FQ2prtdPxZeCyRUYgG/ 46UJM/NqDtwXc0nJ0q6SAb9xSMl58YKwCFKDbHGX/tVevKx8RK6diHCHAXeOi7MjI2lk PvYvOQTx7+W8Qrmx13NqWuMQHWS6psl1gN95m/d/GLgjEpPk3HC1Stf1IKA/Ps6h4Sa/ B5GatoBEuuaROLE0BQKgN++QnG4MC66qo9gYpsjhhVJchmtowGwhpI1s78bjOcQhi51y c6hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zXRGEZPwLtQ5UinxPXKU5BfJwpOCdWN4x79WEBjhqjE=; b=CF/FyemcTaRFV/Xuaa/mMH46/YRIrTDm9JOA3Tf9sL0cXcnqQf/Y81kA9QBaQs+7R0 K6AdP2x5uay9TLuYVSlomxl+8j/q9bjN/pBp/We5ZH4+r5H3LnZJGX9qXHWlJDnqsHQg 0DId+VqU3swaC5LTzzDPqp9O/gpDhBKIQXCGqYDZ1StRf/mtAIndn/qUrh7YSBUEQljI ngqj5ZRo1wiD4O4+Am6St33HnN4z8C6aWtIKKWZsB2wvYmKBOEq8InWcYXTNUs6PeZl+ 4Vhj6soBGpw07974Eewrx+eH1yXiRFCf55Y5kuvz6yJG9Da187ZOMAIVc5W5kOrAP+a6 g3wQ== X-Gm-Message-State: APjAAAUcwhJXzruo7s+aF+4Svatu9IQTTsNSMXQdo4YhqI0lV5wX4ain Q50NjGr8BBLlFSwglW0nHXW3qg== X-Received: by 2002:a1c:ef13:: with SMTP id n19mr3424489wmh.48.1567694819611; Thu, 05 Sep 2019 07:46:59 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id y3sm3568846wra.88.2019.09.05.07.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 07:46:58 -0700 (PDT) Date: Thu, 5 Sep 2019 15:46:55 +0100 From: Matthias Maennich To: Masahiro Yamada Cc: Linux Kernel Mailing List , "Cc: Android Kernel" , Arnd Bergmann , Greg Kroah-Hartman , Jessica Yu , "Joel Fernandes (Google)" , Lucas De Marchi , maco@android.com, sspatil@google.com, Will Deacon , Linux Kbuild mailing list , linux-modules@vger.kernel.org, linux-usb , usb-storage@lists.one-eyed-alien.net, linux-watchdog@vger.kernel.org, Julia Lawall Subject: Re: [PATCH v4 08/12] scripts: Coccinelle script for namespace dependencies. Message-ID: <20190905144655.GB136369@google.com> References: <20180716122125.175792-1-maco@android.com> <20190903150638.242049-1-maennich@google.com> <20190903150638.242049-9-maennich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 04, 2019 at 06:53:25PM +0900, Masahiro Yamada wrote: >On Wed, Sep 4, 2019 at 12:07 AM Matthias Maennich wrote: >> >> A script that uses the '.ns_deps' files generated by modpost to >> automatically add the required symbol namespace dependencies to each >> module. >> >> Usage: >> 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define >> DEFAULT_SYMBOL_NAMESPACE >> 2) Run 'make' (or 'make modules') and get warnings about modules not >> importing that namespace. >> 3) Run 'make nsdeps' to automatically add required import statements >> to said modules. >> >> This makes it easer for subsystem maintainers to introduce and maintain >> symbol namespaces into their codebase. >> >> Co-developed-by: Martijn Coenen >> Signed-off-by: Martijn Coenen >> Acked-by: Julia Lawall >> Reviewed-by: Greg Kroah-Hartman >> Signed-off-by: Matthias Maennich > > >Without any correct dependency, >this does not work. You are right, 'nsdeps' needs to depend on 'modules' to make that work. I will fix that in the next version. >$ make clean; make nsdeps >cat: modules.order: No such file or directory >cat: ./modules.order: No such file or directory > > >I do not see any point in the Makefile changes.