Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1124812ybe; Thu, 5 Sep 2019 10:39:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7Z4dn7mF+sMcONK8P2sJQf4Pj7eIVqOz6X/w7bNkd/46cAYRZJ9n29FWoAEHcTEMdFzlJ X-Received: by 2002:a63:195f:: with SMTP id 31mr4315948pgz.225.1567705162510; Thu, 05 Sep 2019 10:39:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567705162; cv=none; d=google.com; s=arc-20160816; b=rHl8spNpDopotSdUrk7ZgT//Hayg8zg0DOcejZTbc3t6TuCGTcm2u6iWWL9KJC2bKj VJSoGRahki4yKLAY8d9ztpWGRARUVYIXNughdnzG58a/lFHxbGcDWYUSJmkvbj6hoVHt 5F7A0xdBk6jekx0J5ORjeRIGyjFMrwWfqOoMGcs7Sf7kd8weMPEtHEqFCqcjg43rJpf+ atMtSv0dsuwxfCxIhsVCCMtP9lXtr7FjO0johfJM69FuhVcMCu5yVpp0tJSQ63XKPhEk IvHJEZ/O6XOLWjXjLuHczXt3n0HlgURjYr3S0B9E3Gp5DLtlqrDwmP9auI50dUkVRTG8 qAJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uSFRi2LxHyVkGxWDGppQkdgyygUeTjCVhHKgPpKC/XU=; b=HrgJ7pe0yB16t/oHyXZCLdDCVsCE/DkAcifjRfvo3IANexGDabLZyIdtNwLyX5X01h 7JdYYmHDq4EOSGob7oRJKC7f5/9r8U7tsiJt0vtJBq7mUCWPG6tLmOQosf+KMmUybcCS Y1chNH+jr6yW0XJIphTHPHMSjOIbHG8HA67S2wr/z/83offfny0x1DexbYzBCYskhFYO DhwXd1wnUh3ePUwBGCao4ZqALUBSaTBF2bp0cQe5u6WGJxNIySjAPcB8qVVz5j0G1mK2 OfWZwiN+xxCQdoDlNO59yv7z5O3AUlp6kxf5pGdC3usA/ow/r6YsnDiXVPq1Q8e4Wb1x 5T4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f188si2775286pfb.22.2019.09.05.10.39.06; Thu, 05 Sep 2019 10:39:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730780AbfIENms (ORCPT + 99 others); Thu, 5 Sep 2019 09:42:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41426 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfIENms (ORCPT ); Thu, 5 Sep 2019 09:42:48 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FAB9307D976; Thu, 5 Sep 2019 13:42:48 +0000 (UTC) Received: from treble (ovpn-120-170.rdu2.redhat.com [10.10.120.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE3E75DAAC; Thu, 5 Sep 2019 13:42:41 +0000 (UTC) Date: Thu, 5 Sep 2019 08:42:39 -0500 From: Josh Poimboeuf To: Jiri Kosina Cc: Petr Mladek , Joe Lawrence , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [RFC PATCH 2/2] livepatch: Clear relocation targets on a module removal Message-ID: <20190905134239.fmoknq3z422tflst@treble> References: <20190826145449.wyo7avwpqyriem46@treble> <5c649320-a9bf-ae7f-5102-483bc34d219f@redhat.com> <20190904084932.gndrtewubqiaxmzy@pathway.suse.cz> <20190905025055.36loaatxtkhdo4q5@treble> <20190905110955.wl4lwjbnpqybhkcn@pathway.suse.cz> <20190905132344.byfybt6s42cajtfz@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 05 Sep 2019 13:42:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 05, 2019 at 03:31:56PM +0200, Jiri Kosina wrote: > On Thu, 5 Sep 2019, Josh Poimboeuf wrote: > > > > All the indirect jumps are turned into alternatives when retpolines > > > are in place. > > > > Actually in C code those are done by the compiler as calls/jumps to > > __x86_indirect_thunk_*. > > Sure, and the thunks do the redirection via JMP_NOSPEC / CALL_NOSPEC, > which has alternative in it. But the thunks are isolated to arch/x86/lib/retpoline.S. We can't patch that code anyway. -- Josh