Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp181774ybe; Thu, 5 Sep 2019 20:06:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxTBA3caLE2zMyOi4vefVnyphNYp1ynAeKquBipJ5uvTY3EYnuVd7046ithZTAT/rb0hUJh X-Received: by 2002:a17:902:860b:: with SMTP id f11mr6950281plo.48.1567739181202; Thu, 05 Sep 2019 20:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567739181; cv=none; d=google.com; s=arc-20160816; b=wi28aMmgX1Ss7MzR9p/PQClQ8jKt5f1S2uBSQw2AobLDCuYIWwqeS9TVv4VRbBHQbB hpoTPYLrjO8fCbDGCv/cZWpHjCp+UazfaEUR0Js6pdoqctMDEvMP3VQ3qWHBDJaZMD7p LY+Sk9Rq7Eh4+lJ9bMBA65S6BlhBpApcWhh//6WxOZ/+UL5elP8tudoqB/BTCLMoYLL2 3F8vCn8n705VXLpCT6bk0FcFejV08Iat8H4KbEdQXXTdxsgH7TS2FGzfUMugvAerBvNY EqZ42Jk6/YmAGwmxKpxZzJUcRBDZXhDW9NuGjuzqHf2Hn9mSKMDS+v8D53Z3ttZ34rY7 oxCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:from:to :subject:cc:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=/M5vtmCXrJZ2Y/8dz6N+gt8X33XfB4PU4LvW9FAENFw=; b=VjQV4eCujewKbuVlgfOYIT7FIICDhp0fQ2wRR6G9Q7z2+8Gwtso0x4VVSRlSm9Kqcq Nq59MquaM7lejo64IO+9mOrOjJnzG/7VH4llXA8+JsVN/8fsrZlmqP6oAYNv1ST3isDN QOufVJC/5fmB09CmhVDPSK92hEFeaTvooLr+gYwxWF3j3+sjLejudyS+8B7j5F57dyfb L7cWuiykTOpIaZiYHA7EmwcmzBJzTZuJoIiLiE+qHW76KjQZJPctFvNDn4en5SN47ynX GAP3sHsu0/a4NiWdmzfhkv3+MdtK3Yc2Az5yT9zMWhq+357t+WXIyN9CMxxweqsKys3/ qgnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="C5/z6F/7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si3773790plg.56.2019.09.05.20.06.05; Thu, 05 Sep 2019 20:06:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="C5/z6F/7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388687AbfIESvi (ORCPT + 99 others); Thu, 5 Sep 2019 14:51:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:54278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfIESvi (ORCPT ); Thu, 5 Sep 2019 14:51:38 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2BB520825; Thu, 5 Sep 2019 18:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567709498; bh=/M5vtmCXrJZ2Y/8dz6N+gt8X33XfB4PU4LvW9FAENFw=; h=In-Reply-To:References:Cc:Subject:To:From:Date:From; b=C5/z6F/7aQ9evaZh/nFx7qV9hMzyCUHWE6dFzQHXHwOERFMhUvEjXyroRS1vegqR5 eAWEabgpNQYZovf4dUJloyQEC4EOVnaTAonwqgJpUPBwXVhG8ovok84uXOCWSXCpe6 Q9m7v2fdFXUYpEbQpMFMysy5j+icvHU1NbL1u2rs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190826212042.48642-1-sboyd@kernel.org> References: <20190826212042.48642-1-sboyd@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Phil Edworthy Subject: Re: [PATCH v2] clk: Document of_parse_clkspec() some more To: Michael Turquette , Stephen Boyd From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 05 Sep 2019 11:51:36 -0700 Message-Id: <20190905185138.C2BB520825@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2019-08-26 14:20:42) > The return value of of_parse_clkspec() is peculiar. If the function is > called with a NULL argument for 'name' it will return -ENOENT, but if > it's called with a non-NULL argument for 'name' it will return -EINVAL. > This peculiarity is documented by commit 5c56dfe63b6e ("clk: Add comment > about __of_clk_get_by_name() error values"). >=20 > Let's further document this function so that it's clear what the return > value is and how to use the arguments to parse clk specifiers. >=20 > Cc: Phil Edworthy > Signed-off-by: Stephen Boyd > --- Applied to clk-next