Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Sep 2019 11:59:10 -0700
From:   Matthew Wilcox <willy@infradead.org>
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     akpm@linux-foundation.org, rcampbell@nvidia.com,
        jglisse@redhat.com, mhocko@suse.com, aneesh.kumar@linux.ibm.com,
        peterz@infradead.org, airlied@redhat.com, thellstrom@vmware.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory.c: Convert to use vmf_error()
Message-ID: <20190905185910.GS29434@bombadil.infradead.org>
References: <1567708980-8804-1-git-send-email-jrdr.linux@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1567708980-8804-1-git-send-email-jrdr.linux@gmail.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 06, 2019 at 12:13:00AM +0530, Souptick Joarder wrote:
> +++ b/mm/memory.c
> @@ -1750,13 +1750,10 @@ static vm_fault_t __vm_insert_mixed(struct vm_area_struct *vma,
>  	} else {
>  		return insert_pfn(vma, addr, pfn, pgprot, mkwrite);
>  	}
> -
> -	if (err == -ENOMEM)
> -		return VM_FAULT_OOM;
> -	if (err < 0 && err != -EBUSY)
> -		return VM_FAULT_SIGBUS;
> -
> -	return VM_FAULT_NOPAGE;
> +	if (!err || err == -EBUSY)
> +		return VM_FAULT_NOPAGE;
> +	else
> +		return vmf_error(err);
>  }

My plan is to convert insert_page() to return a VM_FAULT error code like
insert_pfn() does.  Need to finish off the vm_insert_page() conversions
first ;-)