Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Sep 2019 14:32:50 -0700
From:   Kees Cook <keescook@chromium.org>
To:     "J. Bruce Fields" <bfields@redhat.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] Remove unused string_escape_*_any_np
Message-ID: <201909051431.65AE98363@keescook>
References: <20190905193604.GC31247@fieldses.org>
 <1567712673-1629-1-git-send-email-bfields@redhat.com>
 <1567712673-1629-4-git-send-email-bfields@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1567712673-1629-4-git-send-email-bfields@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 05, 2019 at 03:44:28PM -0400, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> These aren't called anywhere.

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> 
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
>  include/linux/string_helpers.h | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
> index c28955132234..8a299a29b767 100644
> --- a/include/linux/string_helpers.h
> +++ b/include/linux/string_helpers.h
> @@ -56,25 +56,12 @@ int string_escape_mem(const char *src, size_t isz, char *dst, size_t osz,
>  
>  int string_escape_mem_ascii(const char *src, size_t isz, char *dst,
>  					size_t osz);
> -
> -static inline int string_escape_mem_any_np(const char *src, size_t isz,
> -		char *dst, size_t osz, const char *only)
> -{
> -	return string_escape_mem(src, isz, dst, osz, ESCAPE_ANY_NP, only);
> -}
> -
>  static inline int string_escape_str(const char *src, char *dst, size_t sz,
>  		unsigned int flags, const char *only)
>  {
>  	return string_escape_mem(src, strlen(src), dst, sz, flags, only);
>  }
>  
> -static inline int string_escape_str_any_np(const char *src, char *dst,
> -		size_t sz, const char *only)
> -{
> -	return string_escape_str(src, dst, sz, ESCAPE_ANY_NP, only);
> -}
> -
>  char *kstrdup_quotable(const char *src, gfp_t gfp);
>  char *kstrdup_quotable_cmdline(struct task_struct *task, gfp_t gfp);
>  char *kstrdup_quotable_file(struct file *file, gfp_t gfp);
> -- 
> 2.21.0
> 

-- 
Kees Cook