Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp582690ybe; Fri, 6 Sep 2019 04:15:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwDGeVs6PbflCygKFimv6kafQ5TZb93a2EJgTCCKbHbW2iuap0g2UD7+GMCId4BVW2k6aJW X-Received: by 2002:a17:90a:310:: with SMTP id 16mr9294667pje.100.1567768511844; Fri, 06 Sep 2019 04:15:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567768511; cv=none; d=google.com; s=arc-20160816; b=cAeHFn0KyzlCy1spwqiadE9BDHMTrdskATlbgPYAJbMdQB5YxTOEw8FgMVt5WtLsYw VmwWiC1Kp4t+vrSbACSzbIsL+JjR2Fu08Efmz+QL7QBJfYHuzhszt0ZyYjwWEDbB80Ky lnxoNl95RdukJPlDiu5OYkjfEznmWDcMcx+Sxr2y3sKsHz91WDxhuFvzD/v4ENPs9Enb I901GwsCuu//3FcLh+09UfdUAVyMzik8xru1TQgQ3olUwrNoBURPd/ayWEjfUkuU1J/1 lzDFaTFEdiAPL7nOkhzZjKV8p6dYSSKx4+JlGpxyoYTtuiFo+Pm2kkKnz60F4eQKvlYI EhcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wF5OZHvt0dmFnljxz1OEWZy5JEqw4qmpESNWqH+JtcY=; b=0ImYXYm22cifqyXhciuZpNeHnknRUfyKoWLhVfQAJaM8mrWhUfyfCDKTv4qel8YicO ZMMpRSGrudRB30QeWMRyhowntLMrGJ4DdZTrAZgBgHFGg+7Db5VWPF3GE2cxDYLDJcWv 3jbZ2SgxjqTpryRlkg7G33vfPpywEWagvObIKHOgiDzPfDkDxG/6UgKgWfcbnbWZoTcd 8O/93gOn7gBuOgC7QwfSFgCv/lF0gBI6Fb0NJ8hnkn+DvWAJgJDOWV7QsW/sj2tRuQ9u toGYsTooBdH3OsJmSoqbc0Cu/CIMfmasXfrkAFPY/iPyFhzFB1RZf3oZWMgrqEA7c4Tw u0uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 98si4158607plc.81.2019.09.06.04.14.55; Fri, 06 Sep 2019 04:15:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393007AbfIFKDc (ORCPT + 99 others); Fri, 6 Sep 2019 06:03:32 -0400 Received: from mga14.intel.com ([192.55.52.115]:17260 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388537AbfIFKDc (ORCPT ); Fri, 6 Sep 2019 06:03:32 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 03:03:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="177594355" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 06 Sep 2019 03:03:30 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i6B5V-0004c4-Bu; Fri, 06 Sep 2019 13:03:29 +0300 Date: Fri, 6 Sep 2019 13:03:29 +0300 From: Andy Shevchenko To: "J. Bruce Fields" Cc: linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH 5/9] Remove unused %*pE[achnops] formats Message-ID: <20190906100329.GM2680@smile.fi.intel.com> References: <20190905193604.GC31247@fieldses.org> <1567712673-1629-1-git-send-email-bfields@redhat.com> <1567712673-1629-5-git-send-email-bfields@redhat.com> <20190906100141.GL2680@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190906100141.GL2680@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 06, 2019 at 01:01:41PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 03:44:29PM -0400, J. Bruce Fields wrote: > > From: "J. Bruce Fields" > > > > The [achnops] are confusing, and in practice the only one anyone seems > > to need is the bare %*pE. > > > > I think some set of modifiers here might actually be useful, but the > > ones we have are confusing and unused, so let's just toss these out and > > then rethink what we might want to add back later. > > Have you evaluated potential users of this API. Do they need anything of the > existing functionality? > > mangle_path() > tomoyo_print_bprm() > tomoyo_scan_bprm() > tomoyo_environ() > tomoyo_encode2() > tomoyo_const_part_length() > > Maybe there are more, I didn't check it carefully. This is comment basically to the absent cover letter, means to the entire series. -- With Best Regards, Andy Shevchenko