Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp586370ybe; Fri, 6 Sep 2019 04:18:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZeLCepsCAKBdAnHjAcXU3Hm7AMMKWUBpsTIdOwdh1tDxhA4L7CJhOg22W7MTnnLPR1uX/ X-Received: by 2002:a17:90a:1c7:: with SMTP id 7mr86773pjd.95.1567768725436; Fri, 06 Sep 2019 04:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567768725; cv=none; d=google.com; s=arc-20160816; b=LfNe35sB1QPkZV36z35Orj8+mPdkFAKLAjiRksG9b/I71WpUegM41ELwetADDoWGC2 L5t/+o4z2oprjUQZ8F1Lt+/bQqa3uuMA/hSXHiVkwE7ik74X4X9rFg5PqLh8tzKvQapo y2+/abGreyPG0Sjc/mIHdfNHlYXGb/H71ZZn4dJUSjmqsfaNVAGZBsMuf8FUaCKkJKhh dzfQ2kykv0FvsMTIBkaVAT5zyoDDSJA/BSqKgn6cMgELu540QC4hRSUtc+/rMHaZc6ri BAUnDirp8tdet9b7lQ4GO4wg5CvvVDYKUAIVpR/q9zSVarVtrSm43xEsseMcx48XJO2T +uAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UiWacVWYRi8qsZB+AuIkNl0cMNGZSKp+8etoj+c0om4=; b=locDnjvV0YQnJcPGwIRGGuexgQfW+Oxy43eyt3a9OnxsUFFbcB+4Ylz8ljOA+qszAH 8QhkjKJy0hq+PoDEX4kNA3rhGVl4WL9MaTkt6HU8T6ru80vgA9q1hg+T0s4j4wU+7NVw lGm7ebvIR1j9J+E30VaKf3Vh2TjevRWUKZ7hFZTQwOHiyNHRf5juM/B19dhyJQipHx3k pHHVv4YhSYJaT2BKL4GcX2KXX9PTut0JGZJFQW2HGo4J0QmldGDXEA+szJZXiuIyj6F5 lhepmpz72pzZR485jb5EhtdeTqYEcKeL5AsWK5oy7XRoD+g8UD7EYBL8qvsO28hcj9tm 89Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a26si4169238pgb.276.2019.09.06.04.18.29; Fri, 06 Sep 2019 04:18:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389509AbfIFKRU (ORCPT + 99 others); Fri, 6 Sep 2019 06:17:20 -0400 Received: from mga07.intel.com ([134.134.136.100]:57055 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfIFKRT (ORCPT ); Fri, 6 Sep 2019 06:17:19 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 03:17:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="213103303" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 06 Sep 2019 03:17:17 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i6BIq-0004u8-QB; Fri, 06 Sep 2019 13:17:16 +0300 Date: Fri, 6 Sep 2019 13:17:16 +0300 From: Andy Shevchenko To: "J. Bruce Fields" Cc: linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH 6/9] Eliminate unused ESCAPE_NULL, ESCAPE_SPACE flags Message-ID: <20190906101716.GN2680@smile.fi.intel.com> References: <20190905193604.GC31247@fieldses.org> <1567712673-1629-1-git-send-email-bfields@redhat.com> <1567712673-1629-6-git-send-email-bfields@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567712673-1629-6-git-send-email-bfields@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 05, 2019 at 03:44:30PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > I can see how some finer-grained flags could be useful, but for now I'm > trying to simplify, so let's just remove these unused ones. > > Note the trickiest part is actually the tests, and I still need to check > them. Currently this _tries_ to follow the shorthand character classes which is established by tools. For example, "\s" = "[ \t\r\n\f]". Also it (almost?) matches the counterpart, i.e. string_unescape() classes. So, if we would need something else, perhaps better to do it in the separate flags. -- With Best Regards, Andy Shevchenko