Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp596889ybe; Fri, 6 Sep 2019 04:30:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIqhS1ywvlbJ/l5Wk8f0wGimG0s/A92Co145Tn25g2Dz48bgu9HwqIc/3/cZPY4VbHzdvj X-Received: by 2002:a17:90a:1502:: with SMTP id l2mr7355550pja.140.1567769409300; Fri, 06 Sep 2019 04:30:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567769409; cv=none; d=google.com; s=arc-20160816; b=0eu3ofrr+Nm2D/kRCjeZtjPDQBsZO9WNyYaZwKljz0g/ixk0qiKkw6ZWmRdtx2WW+Z soWtAHjX7w0cpYocDDzQvdbdpJMc8iO6Vo7ok3903dKwJseEgP6So4g8V1EMRngSegry B6IjuQedQgpvZd1QPFw3YOBb/mTI00PR6MPDBkIq+oz4Gf4A6ppp0W2n10+eaSWhKbVm 4sdeUOvTHz0YTqEMrbkA7xSiysfz9BZfo34JbMCYLYItSyrOpmTRR3rh7kXlRHc5g+uj BrCFjwHEW+4sE4WMZxv1v+YQxgz0PwNKRQmodH5YDExsy6jeu0DfY6gJ5x7QTEznj/GE hJFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=YTwDqUKX8TtDKM6rouciZomoDHGw44ENAk5jSefNLFc=; b=DODVQJPBaoBrNR6muUmAaoMwbQUe/5XP6t8gTRz7bkvPL80ebDtru86K8Pslcnh3lm xDsM3/TUpUyMSsYOFUcb8aEAqQg2SHLSAxSty6CGrkSjxkqyQJUocF8Xjt5Doe/Wwj40 P9Z/Ieju6afu8LrAJ/4YgbbmicCR3QoWkublhB3fHRXIvqum2KVfNf62OOBk6mSh9AvK 9Og6lWFA0boJU2xu+Uwu+C0Xow4s2aDiLhVZRm3BiPdNBojLQlom/4vkw/t0uSnHH4Ag C+z9jYDMz8Dyuk7YKKnsHljHKW3R8CsIDuip96zZrVERXKTq3CKWr+Puj/ZMGP/OhYga 5y8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n126si5149593pfn.42.2019.09.06.04.29.50; Fri, 06 Sep 2019 04:30:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732624AbfIFKke (ORCPT + 99 others); Fri, 6 Sep 2019 06:40:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35716 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728269AbfIFKkd (ORCPT ); Fri, 6 Sep 2019 06:40:33 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BB7285363; Fri, 6 Sep 2019 10:40:33 +0000 (UTC) Received: from localhost (ovpn-117-208.ams2.redhat.com [10.36.117.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B74D19C70; Fri, 6 Sep 2019 10:40:25 +0000 (UTC) Date: Fri, 6 Sep 2019 11:40:24 +0100 From: Stefan Hajnoczi To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, miklos@szeredi.hu, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, dgilbert@redhat.com, mst@redhat.com Subject: Re: [PATCH 01/18] virtiofs: Remove request from processing list before calling end Message-ID: <20190906104024.GI5900@stefanha-x1.localdomain> References: <20190905194859.16219-1-vgoyal@redhat.com> <20190905194859.16219-2-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UthUFkbMtH2ceUK2" Content-Disposition: inline In-Reply-To: <20190905194859.16219-2-vgoyal@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 06 Sep 2019 10:40:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UthUFkbMtH2ceUK2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 05, 2019 at 03:48:42PM -0400, Vivek Goyal wrote: > In error path we are calling fuse_request_end() but we need to clear > FR_SENT bit as well as remove request from processing queue. Otherwise > fuse_request_end() triggers a warning as well as other issues show up. >=20 > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Hajnoczi --UthUFkbMtH2ceUK2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl1yN5gACgkQnKSrs4Gr c8iH2Qf9FDlsSyo3aEDCwVuW5ufQrOhFl5xJgIrwu9zF7Q8xWoHeRxDRnuXqrpy0 IBO3sm8mijVdTypCJ8zrFIER28OnXnmNmRuZFPxmlDoSf1/G74BAX7qaLH8NTikF CwJC4TUljhUvvGNKo9/jRu6qVKNcNxz8BXmxjIGBSWWGu90lmDwarFxX6arkWn+x N8E6/S9dUi6f6jiEy0k0zNUUZ+i4bXhM3SsGXaNuoI/GzZQUG8016CUbYKDSxRxo ov0FV+U9gy9GEDbuhy5LI5DrlYOzlpSe8OiNiw031NIlcrGmty1o75Dw4j0Bxzwr zMlTa2f77G2tmrCucSRxbNT2u2u6xw== =1d2m -----END PGP SIGNATURE----- --UthUFkbMtH2ceUK2--