Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp754440ybe; Fri, 6 Sep 2019 06:52:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqz2tYKmJAEhinni3bryvZ2LHJWp3TZyR8GZOWkDzTtErEUg9B72qC+eMdj7g+ET5Eroa08L X-Received: by 2002:a62:3844:: with SMTP id f65mr11018199pfa.142.1567777938316; Fri, 06 Sep 2019 06:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567777938; cv=none; d=google.com; s=arc-20160816; b=h4ikbzfNzUTkDLZVejr3SrGOUP7PgdYldSYE6cY2qahDB86vFX2e+1Rt1BLP6Te1wJ WKn5q8NJEEC9MbyKpILEXm7GLMXO828Gp/zTGrhC0DTiUkuXa6U89OQ1USEP1KaIYNM8 IhqZoUz27b6GBFxFeX0N3uJU+cE8juxih3BiHRMcJD7R1CiQWPzseogsFskw63c3wzSU iJFDdHkWcbBeYklNTYy5omcUpS02tMQDYk+VVbAXQLXqp/X//7eJ9Pk7P3X9EE+KRCJ5 otfcbmnnm7NqKF1IIjcHBXbvCG1lpno6geAuHofJA8gYoDDaNnXqS9EkrlZ49T352odG SuCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v3xn7ZmePc/fMKLKQSmvzLjNcXGMc4XAThIjZvc9sl8=; b=N4fqn9g6vptqD+rakuhWuU2P4Ay59Fm3LgOAdofdVTez9+e0h4I1cJp82zsC/aPKkF JBvNr0KRAufHr+A5YM9+6pm75PPpj+1W8CD6/PkEeYy5zn2e0IoOpwhfhpDglL4vauLG J2EpMJyc/ar2ML3RbZuS8C0mO8M6qbBoHVbnA1aGYZr2vf8B9LobA8VkQFlZB7m/WeVS 15T/Gp1mUVPxMwi6iKakAEL/FBZN3lQ3nd1Q0531YSezqKLi7dXgl2OYkk6E7u7lwJxD WiXJlgYzmJpxfELmi0pQFdH/Yai/yyPtEOT3hNbVecRIfn6bvlaQwO8owPoW0dYE9oXL aXVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qAmxzUva; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a63si4345397pge.113.2019.09.06.06.52.01; Fri, 06 Sep 2019 06:52:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qAmxzUva; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392358AbfIFHUi (ORCPT + 99 others); Fri, 6 Sep 2019 03:20:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45824 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388816AbfIFHUi (ORCPT ); Fri, 6 Sep 2019 03:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=v3xn7ZmePc/fMKLKQSmvzLjNcXGMc4XAThIjZvc9sl8=; b=qAmxzUvaJuz3UwjvBMHXuwGzmM 8R12gdx167llfTzuU/WpDqbwal5N7P77md/C8rsYcdi1tYSWyr2lQh6aRBdqQMqR5f1sTAV3S5L0V SOC0cnKU0t1s0CSntJCSWKwIYnBcHKkQVKEWo7JDvgvlUMlPVLA7kRov6RUCK+DFZ2y/+4z3p4UtI 8ibbU3JWQxRA7Y380QUG6hVJ2myXnOwufOhCJkUD5q9J23OK6k0xb2hUnjzZnDV7WXhxN4LBfGP+J f97XeltIvOXmIirfysBpic3IAIhisIJOU38OgVRVkEkNRdyiwsOa3bTGOqCODeUlR1hAoXcxKlnjl 2HN+zx4w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i68Xt-0007fI-Fh; Fri, 06 Sep 2019 07:20:37 +0000 Date: Fri, 6 Sep 2019 00:20:37 -0700 From: Christoph Hellwig To: Thomas =?iso-8859-1?Q?Hellstr=F6m_=28VMware=29?= Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, "pv-drivers@vmware.com" , Thomas Hellstrom , Dave Hansen , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: dma_mmap_fault discussion Message-ID: <20190906072037.GA29459@infradead.org> References: <20190905103541.4161-1-thomas_os@shipmail.org> <20190905103541.4161-2-thomas_os@shipmail.org> <608bbec6-448e-f9d5-b29a-1984225eb078@intel.com> <20190905152438.GA18286@infradead.org> <20190906063203.GA25415@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 06, 2019 at 09:10:08AM +0200, Thomas Hellstr?m (VMware) wrote: > It's definitely possible. I was just wondering whether it was necessary, but > it seems like it. Yepp. I've pushed a new version out (even hotter off the press) that doesn't require the region for dma_mmap_prepare, and also uses PAGE_SIZE units for the offset / length in dma_mmap_fault, which simplifies a few things.