Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030381AbVLWCXm (ORCPT ); Thu, 22 Dec 2005 21:23:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030382AbVLWCXl (ORCPT ); Thu, 22 Dec 2005 21:23:41 -0500 Received: from mx1.redhat.com ([66.187.233.31]:9435 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1030381AbVLWCXl (ORCPT ); Thu, 22 Dec 2005 21:23:41 -0500 Date: Thu, 22 Dec 2005 21:22:27 -0500 From: Dave Jones To: Adrian Bunk Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: remove incorrect dependancy on CONFIG_APM Message-ID: <20051223022227.GB27537@redhat.com> Mail-Followup-To: Dave Jones , Adrian Bunk , torvalds@osdl.org, linux-kernel@vger.kernel.org References: <20051220212127.GA6833@redhat.com> <20051223021813.GH27525@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051223021813.GH27525@stusta.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1869 Lines: 52 On Fri, Dec 23, 2005 at 03:18:13AM +0100, Adrian Bunk wrote: > On Tue, Dec 20, 2005 at 04:21:27PM -0500, Dave Jones wrote: > > > > >From the PM_LEGACY Kconfig description.. > > > > "Support for pm_register() and friends." > > > > Note, no mention of 'make apm stop working'. > > > > Signed-off-by: Dave Jones > > > > --- linux-2.6.14/arch/i386/Kconfig~ 2005-12-20 16:19:17.000000000 -0500 > > +++ linux-2.6.14/arch/i386/Kconfig 2005-12-20 16:19:21.000000000 -0500 > > @@ -710,7 +710,7 @@ depends on PM && !X86_VISWS > > > > config APM > > tristate "APM (Advanced Power Management) BIOS support" > > - depends on PM && PM_LEGACY > > + depends on PM > >... > > This doesn't compile: > > <-- snip --> > > ... > CC arch/i386/kernel/apm.o > arch/i386/kernel/apm.c: In function 'apm_init': > arch/i386/kernel/apm.c:2304: error: 'pm_active' undeclared (first use in this function) > arch/i386/kernel/apm.c:2304: error: (Each undeclared identifier is reported only once > arch/i386/kernel/apm.c:2304: error: for each function it appears in.) > arch/i386/kernel/apm.c: In function 'apm_exit': > arch/i386/kernel/apm.c:2410: error: 'pm_active' undeclared (first use in this function) > make[1]: *** [arch/i386/kernel/apm.o] Error 1 > > <-- snip --> > > If PM_LEGACY causes user confusion for APM users, commit > bca73e4bf8563d83f7856164caa44d5f42e44cca should be reverted. Yeah, I realised that earlier too, my change was untested. Hrmph. For now I've enabled PM_LEGACY, but silently taking options away like this is what surprises users. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/