Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp823736ybe; Fri, 6 Sep 2019 07:52:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVANE34rqxgI9+dxsYtlcOi0IoHbitT5RAR4Nge8tcrkjYt14W6rLzmUAKw0fNnz+W1gsU X-Received: by 2002:a17:902:20e3:: with SMTP id v32mr9197956plg.142.1567781554623; Fri, 06 Sep 2019 07:52:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567781554; cv=none; d=google.com; s=arc-20160816; b=I53RlQTogRKMsZQBA6EusiWu6Z4HXs2PawMVb5Ryd0QOCgTPZIT5iDgTyI62/Ygljp 1+L1S4f9BJyZm3M1nEs5Ri68zxFW4oh0ixnrXM20GMor3KDhCZvUu4Fx79CRwB0/+RrE /NkKS8oz5hrcf+eVDkiGjzxucFirhC/qVnLBel3+4w/QDrq58Pgqf7f//QlE7vu7BVNk oEzWqUaO24zzb6bnr7bcA0uuuQG+kXmH/fHoBfzUJ+Uaamr1Fv7/gPmgMui/na5oxRJJ UqadfXV8HlmsM9x/CD/GCVXvyGI+n1BsTme2S0UNsxtvlbaIfOEDDIsm9IboAZyqsJ4k 7qug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=d9eCsVlOV0qwfpo9c1jVQsAQiCp5Qrb/vwvQlXE2I0k=; b=BCnb9DjOJe8yha4+TAUnCENsHgARXmnqTUagONVmGE8RcgOYxMfIxsNReZJhdXmLZ3 jzG8L84Y9vuTEs0qoWPfJ46iAfU4a3dAWtQecuXjYNU9GMcFwcN3P5++4kC1ILLcG1w5 iB46ozrP5FdOByjqh6Zk+KK9D5f7OQG2oDgi08echnnTNospH+NACkd1VfoWF87sFJUt HXOLlm5/QreHA0qLzHbY6H7mT332nI0Mfec3kg439RcklroCXgXQApOkiM/rAC4LWjDq E8whsD0zdNMGmzrI6w/obb9EcPaM3n1kHowezkBHTlR0QYkBJkk+7UYEUi5SInNLObNn QSnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=oK6KBT4O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si5979681pfx.193.2019.09.06.07.52.17; Fri, 06 Sep 2019 07:52:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=oK6KBT4O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390603AbfIFKuK (ORCPT + 99 others); Fri, 6 Sep 2019 06:50:10 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52746 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731717AbfIFKuJ (ORCPT ); Fri, 6 Sep 2019 06:50:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=d9eCsVlOV0qwfpo9c1jVQsAQiCp5Qrb/vwvQlXE2I0k=; b=oK6KBT4OdGd26VgBA2+t1oj5P ZFyVJGP0t1PlQxinX44Idet+6CmIzNMrl8IeDbIo7+hvBbRxq3UQCuIHF2yBo+uYiRWfPG4nrX2QB 5QcKF1W2VZLBYtyma9rY9P1IexmPyczHnayaG8bUFtrJWgK01kMwUwCaURCIX27RF9yGc05P+XFbw LK9RwdhfYbCxntWy08cxn9ubnTtP+gnNms/Ic01jE/VxQvMFfg5qUFIbFUCCUgQR1Oyt9QlEVfoGw EYhfCGnoux81FR0kY7UadcdJRfCmUi/aZpxYRccn3L3RSFeleCMLzxRpUlfHjnDJVJ9Z/XSlUjUQM HYfIWchkQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1i6BoM-0006RL-Ca; Fri, 06 Sep 2019 10:49:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 03CAF3011DF; Fri, 6 Sep 2019 12:49:10 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 599DC29E2D2F9; Fri, 6 Sep 2019 12:49:48 +0200 (CEST) Date: Fri, 6 Sep 2019 12:49:48 +0200 From: Peter Zijlstra To: Sergey Senozhatsky Cc: Petr Mladek , John Ogness , Andrea Parri , Sergey Senozhatsky , Steven Rostedt , Brendan Higgins , Thomas Gleixner , Linus Torvalds , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v4 0/9] printk: new ringbuffer implementation Message-ID: <20190906104948.GX2349@hirez.programming.kicks-ass.net> References: <20190807222634.1723-1-john.ogness@linutronix.de> <20190904123531.GA2369@hirez.programming.kicks-ass.net> <20190905130513.4fru6yvjx73pjx7p@pathway.suse.cz> <20190905143118.GP2349@hirez.programming.kicks-ass.net> <20190906090627.GX2386@hirez.programming.kicks-ass.net> <20190906100943.GB10876@jagdpanzerIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190906100943.GB10876@jagdpanzerIV> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 06, 2019 at 07:09:43PM +0900, Sergey Senozhatsky wrote: > --- > diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c > index 139c310049b1..9c73eb6259ce 100644 > --- a/kernel/printk/printk_safe.c > +++ b/kernel/printk/printk_safe.c > @@ -103,7 +103,10 @@ static __printf(2, 0) int printk_safe_log_store(struct printk_safe_seq_buf *s, > if (atomic_cmpxchg(&s->len, len, len + add) != len) > goto again; > > - queue_flush_work(s); > + if (early_console) > + early_console->write(early_console, s->buffer + len, add); > + else > + queue_flush_work(s); > return add; > } You've not been following along, that generates absolutely unreadable garbage.