Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1032812ybe; Fri, 6 Sep 2019 10:49:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqww0Z8Y+8Uj41+l/sPOJBdFzJaACX5CNJABAuHHKLGNNP9Icgae0Le4l4ZK9IV1ZvgV5wYh X-Received: by 2002:a17:902:20c9:: with SMTP id v9mr10165566plg.293.1567792146885; Fri, 06 Sep 2019 10:49:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567792146; cv=none; d=google.com; s=arc-20160816; b=EXhHP7AjrAZLVdQS5Wzv/O5OEtxbZkiiC4V0yCLFUhGJASlmV8dBbNm/J440PmS6va PyZyFTahW3wB5GLy+GPzClC9oIAEyPPWfDa9rixbzvnZt29FvRUovMuhqXoBLf8QCQZT 50/cOxgk8g5RqbFWjDz545Ox5JgYwxvqfjcju+GTtYyttV63VmLRyY7QfTB63UmSKOQI qvnBMIDmzVrAJ7IBYLh4D03nv3A3up+sd04M3wOsCzfPDzjB0utJ+KgfJDeko6wn6Cia L17iNMfEjPKcrxJsYYuL+jkBku5XJuhIA6zONfv6nUeQesaaV+7CuZ9vDRSnEFqjVQB+ rGDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=S7JAE+cx0oa0FNWJFmDozaA+CyN0GVuyeku5LYWHZHo=; b=lQ5vZz+LjBTC5oH1OIE+bKXOCymlFk3r1xyYqWU1ILeG8BPKCO3Q/25ZKuIVdmTut0 l7cCb8zUQrTc5EECetaj0IFEW9M9nJF4e9pHk+61opMag9FB4kb3K+d+ucAkREF6BrCw WzdBfdSjizcbPvRoQmgzcEQ84pmveiFoxyVlCaFEqFjxcktkA6hcnAM03wUbilqjAXHa uVyVKJWZ3Uis/EL360ZfeFDvtR0OFutjho5NKdDYB2JTF6XUz09EB4oVJYzLmfNXM/fw 7vJC3jh4sWYmy1MnXKseOKRu+LHy1myz0WzESVklGkcnEcHwqGpgYHNlOU7cTiETCiWw je4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si5477818plk.13.2019.09.06.10.48.51; Fri, 06 Sep 2019 10:49:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404589AbfIFMGo (ORCPT + 99 others); Fri, 6 Sep 2019 08:06:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33802 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404502AbfIFMGj (ORCPT ); Fri, 6 Sep 2019 08:06:39 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4AA20307D88D; Fri, 6 Sep 2019 12:06:39 +0000 (UTC) Received: from localhost (ovpn-117-208.ams2.redhat.com [10.36.117.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF22B60610; Fri, 6 Sep 2019 12:06:38 +0000 (UTC) Date: Fri, 6 Sep 2019 13:06:37 +0100 From: Stefan Hajnoczi To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, miklos@szeredi.hu, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, dgilbert@redhat.com, mst@redhat.com Subject: Re: [PATCH 17/18] virtiofs: Remove TODO to quiesce/end_requests Message-ID: <20190906120637.GY5900@stefanha-x1.localdomain> References: <20190905194859.16219-1-vgoyal@redhat.com> <20190905194859.16219-18-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lYVfafuUkPqz/tKz" Content-Disposition: inline In-Reply-To: <20190905194859.16219-18-vgoyal@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 06 Sep 2019 12:06:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lYVfafuUkPqz/tKz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 05, 2019 at 03:48:58PM -0400, Vivek Goyal wrote: > We now stop queues and drain all the pending requests from all virtqueues. > So this is not a TODO anymore. >=20 > Got rid of incrementing fc->dev_count as well. It did not seem meaningful > for virtio_fs. >=20 > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Stefan Hajnoczi --lYVfafuUkPqz/tKz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl1yS80ACgkQnKSrs4Gr c8iYtAf+M+W93KWyYjt/Ozu/X8KfP7/va+YH3UjLCSvUxvX5CnMw8go9WAGz79SW h3CwH86zMiiBVTqVtUcV6HyxuDRdKDSLC123iMP5ydQGJYa63zkdGpbq8Xnc3kFB vQdt2JHMqvByjMdtgAzOSdVYb5kslR6VxFrH8xd+fd7x6gKvp4dNE1lDfuI5iUHN vS3OQ2IcSBv1TpPGTRrUhDEcz7N5ebnh5/JQvDbyPbmspchYS+PUvFofzLAQ61Pl 2gKkBnoYAnpHQJwXaFq7aTp/48t2BIsX9j6WrXeK2PjkV2Xa24O1M7jM995KwK+n lHQUmHQMYTsl27X2YQeHusZ4XB1Gdw== =LskU -----END PGP SIGNATURE----- --lYVfafuUkPqz/tKz--