Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 6 Sep 2019 11:45:52 -0300
From:   Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Jessica Yu <jeyu@kernel.org>,
        Federico Vaga <federico.vaga@vaga.pv.it>,
        Thomas Gleixner <tglx@linutronix.de>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: license-rules.txt: cover SPDX headers on Python
 scripts
Message-ID: <20190906114552.524d0d50@coco.lan>
In-Reply-To: <a610efdd3bf488d407dc1130fa8ed090019ccffd.camel@perches.com>
References: <20190905055614.7958918b@coco.lan>
        <88e638eb959095ab6657d295f9f8c27169569bf2.1567675272.git.mchehab+samsung@kernel.org>
        <20190905092703.GA30899@kroah.com>
        <20190905090701.37dcf75e@coco.lan>
        <b32c2e46b91e7bcda2a9bd140673f06d71b2487a.camel@perches.com>
        <20190906083457.7e7934ec@coco.lan>
        <a610efdd3bf488d407dc1130fa8ed090019ccffd.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, 06 Sep 2019 05:20:30 -0700
Joe Perches <joe@perches.com> escreveu:

> On Fri, 2019-09-06 at 08:34 -0300, Mauro Carvalho Chehab wrote:
> > I did some changes on it, plus one change at the pedantic mode of
> > scripts/spdxcheck.py, and placed the corresponding patches at:
> > 
> > 	https://git.linuxtv.org/mchehab/experimental.git/log/?h=spdx_pedantic  
> 
> Overall seems very nice, thanks.
> 
> Couple nits.
> 
> Some of the scripts and py files move the author
> block into a description or add unnecessary blank
> comments.  These may use some manual fixups.

True. I noticed that too. I suspect that fixing this automatically would 
make the script too complex.

Anyway, the point is: who will apply it? Linus? Each maintainer?

I can apply it to the media subsystem (after applying the patches I have 
already doing the same), but I don't intend myself to apply it to the other
subsystems.

> > what's the "very first line" where a
> > SPDX header tag should be on a man page?  
> 
> Beats me.
> This says man pages are documents,
> https://spdx.org/rdf/ontology/spdx-2-0-rev-7/individuals/usageType_document___85292652.html
> 
> 

Yes. I mean, I suspect that a troff file should have a ".TH" at its
first line. So, SPDX header should start at the second line.


Thanks,
Mauro