Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of sony.com designates
 160.33.194.229 as permitted sender) receiver=protection.outlook.com;
 client-ip=160.33.194.229; helo=usculsndmail02v.am.sony.com;
From:   <Tim.Bird@sony.com>
To:     <arnd@arndb.de>, <brendanhiggins@google.com>
CC:     <gregkh@linuxfoundation.org>, <logang@deltatee.com>,
        <sboyd@kernel.org>, <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] kunit: add PRINTK dependency
Thread-Topic: [PATCH] kunit: add PRINTK dependency
Thread-Index: AQHVZMfa56x9Vc3vGku2oQRhqtfXBqcexmWQ
Date:   Fri, 6 Sep 2019 15:31:02 +0000
Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF977A9B7B@USCULXMSG01.am.sony.com>
References: <20190906152800.1662489-1-arnd@arndb.de>
In-Reply-To: <20190906152800.1662489-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2019 15:31:33.4109
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 54bcd044-0d71-44a3-5437-08d732df4c7f
X-MS-Exchange-CrossTenant-Id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=66c65d8a-9158-4521-a2d8-664963db48e4;Ip=[160.33.194.229];Helo=[usculsndmail02v.am.sony.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR13MB1839
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Minor spelling nit..

> -----Original Message-----
> From: Arnd Bergmann
>=20
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
>=20
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit'=
 [-
> Werror,-Wimplicit-function-declaration]
>=20
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
depenedency -> dependency

>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kunit/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
>=20
>  config KUNIT
>  	bool "Enable support for unit tests (KUnit)"
> +	depends on PRINTK
>  	help
>  	  Enables support for kernel unit tests (KUnit), a lightweight unit
>  	  testing and mocking framework for the Linux kernel. These tests are
> --
> 2.20.0