Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] watch_queue: make locked_vm accessible
To:     Arnd Bergmann <arnd@arndb.de>, David Howells <dhowells@redhat.com>
Cc:     Jann Horn <jannh@google.com>, linux-kernel@vger.kernel.org
References: <20190906153249.1864324-1-arnd@arndb.de>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <1bfa4486-96db-dd83-dc6d-433302f3235f@kernel.dk>
Date:   Fri, 6 Sep 2019 09:39:36 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190906153249.1864324-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/6/19 9:32 AM, Arnd Bergmann wrote:
> The locked_vm member of struct user_struct is guarded by an #ifdef,
> which breaks building the new watch_queue driver when all the other
> subsystems that need it are disabled:
> 
> drivers/misc/watch_queue.c:315:38: error: no member named 'locked_vm' in 'struct user_struct'; did you mean 'locked_shm'?
> 
> Add watch_queue to the list.

Should we either:

1) Make it unconditionally available

or

2) Introduce a symbol for this that others can select, like
   CONFIG_NEEDS_USER_LOCKED_VM or something like that.

?

-- 
Jens Axboe