Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kunit: add PRINTK dependency
To:     Arnd Bergmann <arnd@arndb.de>,
        Brendan Higgins <brendanhiggins@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        Stephen Boyd <sboyd@kernel.org>,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org,
        "skh >> Shuah Khan" <skhan@linuxfoundation.org>
References: <20190906152800.1662489-1-arnd@arndb.de>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <5dfe1bfc-0236-25cf-756b-ce05f7110136@linuxfoundation.org>
Date:   Fri, 6 Sep 2019 09:39:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190906152800.1662489-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/6/19 9:27 AM, Arnd Bergmann wrote:
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
> 
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-Werror,-Wimplicit-function-declaration]
> 
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   kunit/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
>   
>   config KUNIT
>   	bool "Enable support for unit tests (KUnit)"
> +	depends on PRINTK
>   	help
>   	  Enables support for kernel unit tests (KUnit), a lightweight unit
>   	  testing and mocking framework for the Linux kernel. These tests are
> 

Hi Arnd,

This is found and fixed already. I am just about to apply Berndan's
patch that fixes this dependency. All of this vprintk_emit() stuff
is redone.

thanks,
-- Shuah