Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030526AbVLWNgK (ORCPT ); Fri, 23 Dec 2005 08:36:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030527AbVLWNgK (ORCPT ); Fri, 23 Dec 2005 08:36:10 -0500 Received: from omta01ps.mx.bigpond.com ([144.140.82.153]:40953 "EHLO omta01ps.mx.bigpond.com") by vger.kernel.org with ESMTP id S1030526AbVLWNgJ (ORCPT ); Fri, 23 Dec 2005 08:36:09 -0500 Message-ID: <43ABFD47.3080000@bigpond.net.au> Date: Sat, 24 Dec 2005 00:36:07 +1100 From: Peter Williams User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Trond Myklebust CC: Kyle Moffett , Ingo Molnar , Con Kolivas , Linux Kernel Mailing List Subject: Re: [PATCH] sched: Fix adverse effects of NFS client on interactive response References: <43A8EF87.1080108@bigpond.net.au> <1135145341.7910.17.camel@lade.trondhjem.org> <43A8F714.4020406@bigpond.net.au> <1135171280.7958.16.camel@lade.trondhjem.org> <962C9716-6F84-477B-8B2A-FA771C21CDE8@mac.com> <1135172453.7958.26.camel@lade.trondhjem.org> <43AA0EEA.8070205@bigpond.net.au> <1135289282.9769.2.camel@lade.trondhjem.org> <43AB29B8.7050204@bigpond.net.au> <1135292364.9769.58.camel@lade.trondhjem.org> <1135297525.3685.57.camel@lade.trondhjem.org> <43AB69B8.4080707@bigpond.net.au> <1135330757.8167.44.camel@lade.trondhjem.org> <43ABD639.2060200@bigpond.net.au> <1135342262.8167.143.camel@lade.trondhjem.org> In-Reply-To: <1135342262.8167.143.camel@lade.trondhjem.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH PLAIN at omta01ps.mx.bigpond.com from [147.10.133.38] using ID pwil3058@bigpond.net.au at Fri, 23 Dec 2005 13:36:07 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2005 Lines: 51 Trond Myklebust wrote: > On Fri, 2005-12-23 at 21:49 +1100, Peter Williams wrote: > >>No. It is asking whether the NORMAL interruption of this interruptible >>sleep will be caused by a human user action such as a keystroke or mouse >>action. For the NFS client the answer to that question is unequivically >>no. It's not a matter of policy it's a matter of fact. > > > /* > * Tasks that have marked their sleep as noninteractive get > * woken up without updating their sleep average. (i.e. their > * sleep is handled in a priority-neutral manner, no priority > * boost and no penalty.) > */ > > This appears to be the only documentation for the TASK_NONINTERACTIVE > flag, I guess it makes to many assumptions about the reader's prior knowledge of the scheduler internals. I'll try to make it clearer. > and I see no mention of human user actions in that comment. The > comment rather appears to states that this particular flag is designed > to switch between two different scheduling policies. Changes of scheduling policy only occur via calls to sched_setscheduler(). > > If the flag really is only about identifying sleeps that will involve > human user actions, then surely it would be easy to set up a short set > of guidelines in Documentation, say, that spell out exactly what the > purpose is, and when it should be used. Sounds reasonable. I'll propose some changes to the scheduler documentation. > That should be done _before_ one starts charging round converting every > instance of TASK_INTERRUPTIBLE. Peter -- Peter Williams pwil3058@bigpond.net.au "Learning, n. The kind of ignorance distinguishing the studious." -- Ambrose Bierce - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/