Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2442389ybe; Sat, 7 Sep 2019 16:01:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzNx9tEXh/qeoOYMYNjJD1vOtLMgKi4hrF3pCm/vW5FaKDTZcZr4p+PrAkQUmhXrYfgqT8C X-Received: by 2002:a17:902:b097:: with SMTP id p23mr17159232plr.261.1567897296956; Sat, 07 Sep 2019 16:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567897296; cv=none; d=google.com; s=arc-20160816; b=DDVmm83VT/YzUHaA1yCKs/0xvr0QjJ+uiZglV3vqL8Ifw0FxNyp2KD6KhVNhLMFXKm ZIFGmLICYi86rD6u7pqXo4WMt1G+/C9ikEcszWF15SjK0eSnM7l1TaiNpX/TVwzxLPVX HTtWusnuBvSlFPaJgszXfQn2VPiq2YGRmt4rkvy5YAlDB8gun/Z1CtDhPwEafNYlx0Z7 bjoYLm30X9vI5Kcxx72vHezEr35eCjsSkhZ2XjiLQREX2o9JML1v7NPs3NrcZku4iJwM KP9Fz72f9uL+XKeEOXZTalgQUvGfzsAADdJIa8FHKMBn9RqlI7EG7q/tRbHdGDdOGKDP 0PIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mOCwqbFB7vKSRBhomaXxUqeJyEFFfN1wyA9xBhT61V0=; b=dPgiYQg9Xh8woCiOsaQEe9uR/hSGSAYvi1MJcCs5cGsZ7t8uJvrpHhE6znqjk4lnXy T22Lx6FdnHwquiDj+wGodqe07WvreNmbyyvo/zolgcOV3zjEV6O/1pyrOivXHNvA29yt 5rqLmJ0qTIghcUSIZ50Y6f+vFXvyrCTT1uMwDnwXo8yjHRFtGiOux6blZdM+IpcOnQO0 dNm2ZQvNXaM4EeoC9uhTWvAJ+4Haph5QyoGe9I26iZQ6xzVLCyiKD6CNlsEscLBigGXN Qu/tlJE32b42hmGVHkVOaItAjY06PUk2EMeFy147831Rg+j3ggjTWc6gWKMfWrrYuBLT 2WZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=ZcY8rBbz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h26si8012695pgl.398.2019.09.07.16.01.05; Sat, 07 Sep 2019 16:01:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=ZcY8rBbz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393338AbfIFTk4 (ORCPT + 99 others); Fri, 6 Sep 2019 15:40:56 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60450 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732554AbfIFTkz (ORCPT ); Fri, 6 Sep 2019 15:40:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mOCwqbFB7vKSRBhomaXxUqeJyEFFfN1wyA9xBhT61V0=; b=ZcY8rBbzBNpiMS57Uqs5UEmfKO woVzYLamMCeN3cnsH9EnjpreeFZ+UvjDegqwjvOzdu8j+I35987RhwVHbF8MmBGpDWg1/wChe/O+Y JcS51ULjP20OoocoE6XFUienDGyserFRKao7rGl9eV4/KYqXOZ+EWTZaA9PfUOe/skA4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i6K6E-0000zz-OA; Fri, 06 Sep 2019 21:40:50 +0200 Date: Fri, 6 Sep 2019 21:40:50 +0200 From: Andrew Lunn To: zhong jiang Cc: davem@davemloft.net, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ethernet: micrel: Use DIV_ROUND_CLOSEST directly to make it readable Message-ID: <20190906194050.GB2339@lunn.ch> References: <1567698828-26825-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567698828-26825-1-git-send-email-zhongjiang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 05, 2019 at 11:53:48PM +0800, zhong jiang wrote: > The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d > but is perhaps more readable. Hi Zhong Did you find this by hand, or did you use a tool. If a tool is used, it is normal to give some credit to the tool. Thanks Andrew