Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Arnd Bergmann <arnd@arndb.de>
CC:     Bernard Metzler <bmt@zurich.ibm.com>,
        Doug Ledford <dledford@redhat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrew Morton <akpm@linux-foundation.org>,
        John Hubbard <jhubbard@nvidia.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rdma/siw: fix NOMMU build
Thread-Topic: [PATCH] rdma/siw: fix NOMMU build
Thread-Index: AQHVZMU+LvVEBVeztU6/43oPJmdmBqcf0+QA
Date:   Sat, 7 Sep 2019 07:34:46 +0000
Message-ID: <20190907073444.GB3873@mellanox.com>
References: <20190906151028.1064531-1-arnd@arndb.de>
In-Reply-To: <20190906151028.1064531-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [81.218.143.71]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4b262804-99e7-4cdf-4fe9-08d73365db7d
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB6160;
x-ms-traffictypediagnostic: VI1PR05MB6160:
x-microsoft-antispam-prvs: <VI1PR05MB61602B12002F70E2BE9477E3CFB50@VI1PR05MB6160.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 0153A8321A
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(189003)(199004)(66946007)(316002)(54906003)(66446008)(64756008)(33656002)(2906002)(6116002)(66476007)(3846002)(66556008)(14454004)(99286004)(86362001)(305945005)(1076003)(8676002)(478600001)(52116002)(7736002)(14444005)(71200400001)(256004)(71190400001)(81166006)(66066001)(6436002)(26005)(2616005)(6512007)(476003)(486006)(186003)(102836004)(4326008)(446003)(11346002)(386003)(6486002)(76176011)(229853002)(6506007)(25786009)(8936002)(5660300002)(36756003)(53936002)(6246003)(6916009)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB6160;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: tJGM1J1eyODS4REme2yPa60Dxy4HAK96g3eJ4dKZ0WvmFH+ZawkGVvCwlQ1NnGXmejRTyH25lp6dWnKH9nLB5utBcEZ01E3bEt30zVMhYwaG5g6oql/PbvgR1ZNM720h6PepZ7TvUoJRCNIO0frvFbvyYVlcz768njxuQVJF0PxAMhcuN1GZzkMV4rehrPFkTyy5hQdw4AanDZXX5tjWxF4l36ICeTOhyvadzpjGoqCedAVfXq/m4EvYztXL2AjzoRwPuzc4QYUhI2xcfTJ2QF6pagbQ/w9v/VOe1ocMyYe6+OUpgQaLuRuOlRhYF331FtblAm/CumrfoV+1aB3qRK6JwzoNvHcX3Zq5TSt9g/NCaxvokebNPTOniw1yEHfARjAfUIaTO49hjs+I8RkB4OIKsHctlqxKFJfwfMwYa9E=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EAD6BCF316711A4C919CFBF15B106EFD@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b262804-99e7-4cdf-4fe9-08d73365db7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2019 07:34:46.9926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z1iOhfrp2s2Wu786ffUrNpFmf20nhUYvgTejmMPGx4X7HWgQJ7aBvoG1Pig81LtIOD+j0fsrHPSluZbNAHlecA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6160
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 06, 2019 at 05:10:10PM +0200, Arnd Bergmann wrote:
> On kernels without CONFIG_MMU, we get a link error for the siw
> driver:
>=20
> drivers/infiniband/sw/siw/siw_mem.o: In function `siw_umem_get':
> siw_mem.c:(.text+0x4c8): undefined reference to `can_do_mlock'
>=20
> I don't know whether this driver is able to work at all without
> an MMU, but it's easy to avoid the link problem by adding another
> compile-time check.
>=20
> Fixes: 2251334dcac9 ("rdma/siw: application buffer management")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>  drivers/infiniband/sw/siw/siw_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/infiniband/sw/siw/siw_mem.c b/drivers/infiniband/sw/=
siw/siw_mem.c
> index e99983f07663..b3b614c07fdb 100644
> +++ b/drivers/infiniband/sw/siw/siw_mem.c
> @@ -374,7 +374,7 @@ struct siw_umem *siw_umem_get(u64 start, u64 len, boo=
l writable)
>  	unsigned int foll_flags =3D FOLL_WRITE;
>  	int num_pages, num_chunks, i, rv =3D 0;
> =20
> -	if (!can_do_mlock())
> +	if (!IS_ENABLED(CONFIG_MMU) || !can_do_mlock())
>  		return ERR_PTR(-EPERM);

I feel like !CONFIG_MMU should provide a dummy inline stub for can_do_mlock
instead?

Jason