Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
From:   Sandro Volery <sandro@volery.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] Fixed most indent issues in tty_io.c
Date:   Sat, 7 Sep 2019 21:51:39 +0200
Message-Id: <9A23770B-49B8-4DB1-8B45-22F3650E0CB8@volery.com>
References: <a99b7481f26138ea01de0d271e9aec2a525c0aed.camel@perches.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        jslaby@suse.com
In-Reply-To: <a99b7481f26138ea01de0d271e9aec2a525c0aed.camel@perches.com>
To:     Joe Perches <joe@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 7 Sep 2019, at 21:27, Joe Perches <joe@perches.com> wrote:
> 
> ﻿On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote:
>>> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
>>> 
>>>>>> On 7 Sep 2019, at 19:29, Greg KH <gregkh@linuxfoundation.org> wrote:
>>>>> ﻿On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
>>>>> Dear Greg,
>>>>> I am pretty sure the issue was, that I did too many things at once. However, all the things I did are related to spaces / tabs, maybe that still works?
>>>> 
>>>> <snip>
>>>> 
>>>> For some reason you sent this only to me, which is a bit rude to
>>>> everyone else on the mailing list.  I'll be glad to respond if you
>>>> resend it to everyone.
>>> 
>>> I'm sorry, newbie here. I thought it'd be better to not annoy everyone with responses but learning things everyday I guess :)
>> 
>> No problem, but you should also line-wrap your emails :)
>> 
>>> I am pretty sure the issue with my patch was that there was too many changes, however all of them were spaces and tabs related, so I think this could be fine?
>> 
>> As the bot said, break it out into "one patch per logical change", and
>> "fix all whitespace issues" is not "one logical change".
> 
> As long as git diff -w shows no difference and a compiled
> object comparison before and after the change shows no
> difference, I think it's fine.

My thoughts, too. I didn't feel comfortable arguing as a newbie tho
so I'll see what I can do once I get home.

> 
> In fact, it avoid multiple commits where the only changes
> are whitespace.
> 
> 
>