Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Daniel Vetter <daniel.vetter@ffwll.ch>
CC:     LKML <linux-kernel@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        "syzbot+aaedc50d99a03250fe1f@syzkaller.appspotmail.com" 
        <syzbot+aaedc50d99a03250fe1f@syzkaller.appspotmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?iso-8859-1?Q?J=E9r=F4me_Glisse?= <jglisse@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Michal Hocko <mhocko@suse.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, notifier: Fix early return case for new lockdep
 annotations
Thread-Topic: [PATCH] mm, notifier: Fix early return case for new lockdep
 annotations
Thread-Index: AQHVZNssp1bwyLm3pUuFKcXxTfYpMqcf036A
Date:   Sat, 7 Sep 2019 07:33:58 +0000
Message-ID: <20190907073355.GA3873@mellanox.com>
References: <20190906174730.22462-1-daniel.vetter@ffwll.ch>
In-Reply-To: <20190906174730.22462-1-daniel.vetter@ffwll.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [81.218.143.71]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1ff8079b-45af-404f-6b9f-08d73365be8a
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB6160;
x-ms-traffictypediagnostic: VI1PR05MB6160:
x-microsoft-antispam-prvs: <VI1PR05MB61608D88A6DEA6767F6F5B8BCFB50@VI1PR05MB6160.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 0153A8321A
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(189003)(199004)(66946007)(316002)(54906003)(66446008)(64756008)(33656002)(2906002)(6116002)(66476007)(3846002)(66556008)(14454004)(99286004)(86362001)(7416002)(305945005)(1076003)(8676002)(478600001)(52116002)(7736002)(14444005)(71200400001)(256004)(71190400001)(81166006)(66066001)(6436002)(26005)(2616005)(6512007)(476003)(486006)(186003)(102836004)(4326008)(446003)(11346002)(386003)(6486002)(76176011)(229853002)(6506007)(25786009)(8936002)(5660300002)(36756003)(53936002)(6246003)(6916009)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB6160;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 3dsB2eVoC1g2cNY6O/8Rremf9AkuM2kF2SLL7nS95dMg8FK4Bdt2aNIR6UJlzuB88xl6/vkzAdoqJgqEWy/WJt/kg85g4Aw2B+m2LpO8Ypsvp2mtEcq8q29mCYMQkKpF0vrDVhWJFa/ytCR8FSiIWJn0gLrVUjbhpsmFS/0nsZDWIH1YStyYb94xcfGb1Vy4Hxe5zM6dzVrxZyN792Z37v6cFH+DVqh5R9UMuyl/5ZBUbFzCSnVS1gzAmu+OC9zSaIVcR+KPxSQoDzBLSlpmVCCbPmViDK9Z67+fNbxKERWKHkgKDFFveYrk3GJNYsd9knOI7EVUsMC1r2JbTNaWZm2IcBDBy3eproIUSzmHDiXvSvXiSlMVBuvdKhH07jnoS469Yt+/oEV1/jyhbTbI6mEsLFURLSh/vuOxYYZEDkk=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5E3C899ACA82F04791826B13EDEB3254@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ff8079b-45af-404f-6b9f-08d73365be8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2019 07:33:58.5975
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aksp3MTsVJn3W5EHCDyn/P0JIgkYL9MnNd5UPmxm/2QraF9VQXm5WoO2GTUoAvMpqMOIhWQZthKTacSr4KrhOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6160
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 06, 2019 at 07:47:30PM +0200, Daniel Vetter wrote:

> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index 5a03417e5bf7..4edd98b06834 100644
> +++ b/include/linux/mmu_notifier.h
> @@ -356,13 +356,14 @@ mmu_notifier_invalidate_range_start(struct mmu_noti=
fier_range *range)
>  static inline int
>  mmu_notifier_invalidate_range_start_nonblock(struct mmu_notifier_range *=
range)
>  {
> +	int ret =3D 0;
>  	lock_map_acquire(&__mmu_notifier_invalidate_range_start_map);
>  	if (mm_has_notifiers(range->mm)) {
>  		range->flags &=3D ~MMU_NOTIFIER_RANGE_BLOCKABLE;
> -		return __mmu_notifier_invalidate_range_start(range);
> +		ret =3D __mmu_notifier_invalidate_range_start(range);
>  	}
>  	lock_map_release(&__mmu_notifier_invalidate_range_start_map);
> -	return 0;
> +	return ret;

Gar, yes. Since nobody has grabbed hmm.git I've squashed this into the
original patch and fixed the checkpatch warning about missing line
after the ret

Everything should be in linux-next the next time it builds

Thanks,
Jason