Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190907020631.29359-1-yamada.masahiro@socionext.com>
In-Reply-To: <20190907020631.29359-1-yamada.masahiro@socionext.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sat, 7 Sep 2019 14:53:16 +0200
Message-ID: <CAK8P3a2GRZJQThJAdavv_EKp27dtUtysKtpYpkKSSupTJ4qemg@mail.gmail.com>
Subject: Re: [PATCH] samples: watch_queue: add HEADERS_INSTALL dependency
To:     Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     David Howells <dhowells@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christian Brauner <christian@brauner.io>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Sep 7, 2019 at 4:07 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> samples/watch_queue/Makefile specifies the header search path
> -I$(objtree)/usr/include, which is probaby needed to include
> <linux/watch_queue.h> etc.
>
> To make it work properly, add "depends on HEADERS_INSTALL" so that
> headers are installed into $(objtree)/usr/include before building
> this sample.
>
> Fixes: 7141642ed120 ("Add sample notification program")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Tested-by: Arnd Bergmann <arnd@arndb.de>

> Arnd reported a build error:
> https://lkml.org/lkml/2019/9/6/665
>
> Missing "depends on HEADERS_INSTALL" is the only reason
> I have in my mind.
>
> If it still fails to build, I do not know why.

It works, thanks for the fix!

       Arnd