Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190906151028.1064531-1-arnd@arndb.de> <20190907073444.GB3873@mellanox.com>
In-Reply-To: <20190907073444.GB3873@mellanox.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sat, 7 Sep 2019 14:57:40 +0200
Message-ID: <CAK8P3a1jy9gmyM=8LDTVep_zqxfhG05dgCyxvn=69NVR+Xmnqw@mail.gmail.com>
Subject: Re: [PATCH] rdma/siw: fix NOMMU build
To:     Jason Gunthorpe <jgg@mellanox.com>
Cc:     Bernard Metzler <bmt@zurich.ibm.com>,
        Doug Ledford <dledford@redhat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrew Morton <akpm@linux-foundation.org>,
        John Hubbard <jhubbard@nvidia.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Sep 7, 2019 at 9:34 AM Jason Gunthorpe <jgg@mellanox.com> wrote:
> > @@ -374,7 +374,7 @@ struct siw_umem *siw_umem_get(u64 start, u64 len, bool writable)
> >       unsigned int foll_flags = FOLL_WRITE;
> >       int num_pages, num_chunks, i, rv = 0;
> >
> > -     if (!can_do_mlock())
> > +     if (!IS_ENABLED(CONFIG_MMU) || !can_do_mlock())
> >               return ERR_PTR(-EPERM);
>
> I feel like !CONFIG_MMU should provide a dummy inline stub for can_do_mlock
> instead?

Fair enough. I've added that to my test tree in place of my first patch
and will send it after some more build testing.

     Arnd