Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3722101ybe; Sun, 8 Sep 2019 20:37:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwptxrHkr+p6uL0BflvVsTBPIHG+u03HfaKa8g+VnAUAvqdkXwGCl0+3jj9Wv8dl4ukXvA0 X-Received: by 2002:aa7:da18:: with SMTP id r24mr22630584eds.37.1568000258168; Sun, 08 Sep 2019 20:37:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568000258; cv=none; d=google.com; s=arc-20160816; b=k6oVdXlaZs9U88duFj3ScSbn7v0OdkongHjAr1A8XWByozIl/yZDObPZCQE2z/40yW tvhxd7iwEQjXokiOocHjFQgnDU6VNQDDhrc5UeQQzwVanD8R20VkykmEoQ+dKGvNiU/e UmwkqhUW8AZOf/6yV1Db8GQui0qdPHJ3KpiO41AnKrdm2k/f0H8mu8fWvv5NqpGqfwHb RGUNekZuJkhwQeVJzwHLffIREgh1SPgKyopOSs9oESKeTN84G/OvpDkV4aXYTCalc0Vm soy1mlec2wiAtVTynepwHWDAarICnVq9MltKsRxzUUYHmkcbe7MlQufbB7VzD19UKz11 niEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=A6Yx4Q7ZNAktHMtoIkw9cxLVNxvnMooP+6PjQIzFBLc=; b=SF801IcyiwebVpIZaWqDlBjLrPO10XrYdznoKzh3XUN/5QkxdU1fc6/CST3M5Z6Szi EDe3f49rCpHUi3F8CpJboOsrhcmhpLk4mv4RhyTzEBXa0y81WGXTBDQFS2E7t7lnT+AP xXuF0Ej2ids0QHuzkQVwp7kV6COIdWW40GsSsh2ajpcBCV+XEKMSr5/GFDuDC/B5p1t6 UC+NOk2LrH8TiX+THlZLOtX2B6PMzJZtj9dGqVprBpF3YnojRAJkR0VhlV1RxhK2JkAI rpdiPC8UDglVESEkERRvrRQD9aNlnCCC2s7WDV7q+UnnDtFzM4KkMElda4Q+b0wkmt30 qMhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ocs8/0bk"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pg18si6638405ejb.122.2019.09.08.20.37.14; Sun, 08 Sep 2019 20:37:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ocs8/0bk"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406182AbfIGRmJ (ORCPT + 99 others); Sat, 7 Sep 2019 13:42:09 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:33266 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389269AbfIGRmI (ORCPT ); Sat, 7 Sep 2019 13:42:08 -0400 Received: by mail-pf1-f195.google.com with SMTP id q10so6612656pfl.0; Sat, 07 Sep 2019 10:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A6Yx4Q7ZNAktHMtoIkw9cxLVNxvnMooP+6PjQIzFBLc=; b=ocs8/0bksVzpQ95cJR3AwWOOV9i513yrPdmP6gDKvtyQvEXcoG71bn2ge1hJqtpafb tfWqJoBj7iR/Wor7Z3xKECddouy9Z8L+UZdcazQK/pQWia1N6UV4qH7K7uBBk3SElx9Y IlgPgsHN0XLa0c+Z7HapbhZKTtVViNB8hvxMvYbHssYfeCQclFUi+PlNW9sR3xSrRFNM nYlpLTgAOSCoaovHrZ1p3cEMv1v0EbUpWeKRg4VYyxeTL2sAf+0/kF3nr2h27su6Mp9Z m5ink4/eWgbxr2HIrt9ZkvHJ8iuxJJcIbLAYTEU/EgatG2Dm5m4yPA+OWpuxDuqNg43F lQVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A6Yx4Q7ZNAktHMtoIkw9cxLVNxvnMooP+6PjQIzFBLc=; b=ILO0fyuRhsqvtjrWXotOPlD08el5l8i0R41p+zpNy+lIoS8G/EvZVzgtFdX5P5haKR EyJUDqJagocl6nItrIWUEQX/d4adSub7RsEwLzS9pWIyWWQtvUvbfAWWKT6WbJHeHDiA N3ExXjJkRBxhdOiGsD9XI1VHf6ZjaHH0jzoTN3w7qJO8A+aq86H9Ac0UZ2W6bKyMhXrX 3uLaBOviSlrNnbjDNLvxZQLlwyXzUZ/POEL2yPs8xDH4CICXbGkXZq9fYCZ/HYuFdvSn gyHmfMrEJhAcda8bc/vpygowabrWZvlRj3E/q6lbciCpFEz5dgEI9GO4XVFGWdDFM9kH 4MDQ== X-Gm-Message-State: APjAAAUCN4BlTs19TpH9Nl+16To7AR21dB4JPmKOvUa7UinXdY4pM5gJ gbQd/ByAne2k5Qf6YnkcVk4Qn2tJwpr+ijYwJ4M= X-Received: by 2002:a63:1020:: with SMTP id f32mr14018816pgl.203.1567878128129; Sat, 07 Sep 2019 10:42:08 -0700 (PDT) MIME-Version: 1.0 References: <20190628033413.8058-1-rajatja@google.com> In-Reply-To: From: Andy Shevchenko Date: Sat, 7 Sep 2019 20:41:57 +0300 Message-ID: Subject: Re: [PATCH v7] platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1" To: Rajat Jain Cc: Rajneesh Bhardwaj , Vishwanath Somayaji , Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List , Rafael J Wysocki , Srinivas Pandruvada , Furquan Shaikh , Evan Green , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 23, 2019 at 1:44 AM Rajat Jain wrote: > > On Thu, Jun 27, 2019 at 8:34 PM Rajat Jain wrote: > > > > Most modern platforms already have the ACPI device "INT33A1" that could > > be used to attach to the driver. Switch the driver to using that and > > thus make the intel_pmc_core.c a pure platform_driver. > > > > Some of the legacy platforms though, may still not have this ACPI device > > in their ACPI tables. Thus for such platforms, move the code to manually > > instantiate a platform_device into a new file of its own. This would > > instantiate the intel_pmc_core platform device and thus attach to > > the driver, if the ACPI device for the same ("INT33A1") is not present > > in a system where it should be. This was discussed here: > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1966991.html > > > HI Andy, Rajneesh, this seems to have fallen through the cracks. Any > comments here on this patch? % git tag --list v5.3* --contains b02f6a2ef0a1 v5.3-rc1 -- With Best Regards, Andy Shevchenko