Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3815795ybe; Sun, 8 Sep 2019 22:48:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9LSCMRvRrlxWZhK2iU1jOv6S9zX8W7B+K5LzsgUDjvWyNyooOPub4iCtEbe2U/QCOU9KV X-Received: by 2002:a17:906:b34a:: with SMTP id cd10mr18028067ejb.300.1568008093766; Sun, 08 Sep 2019 22:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568008093; cv=none; d=google.com; s=arc-20160816; b=CsjpShw2v+NlxBSod1mK2RnENmCwpFSANTN6Xovb8g10+VKm1UPNpkXwy1x0V7x+vq 0R5M/potobb184IK/Po3yNw3r4NnbdIG+oA7E4kIc/tGVPGXDiWsqwwZ8x+Iwo8n6RjO AGDne64I1Mdm2+gMv7zUR2lWfjAwWLPbLqR2KiPTa2vn6HK1ANzXYULfvwfiqxdYGHWs 6JWWCdU76Sw+SYiV7Jxqp2V4p2/H/cY9R2izzV4aVbhrbljDxujx1mbYjie5mMrayulv IynfO7p9aejc7Ryol1V2IeVZeXdJGZhNJj0k5xyz800ETYl2o3ss91AdnFOVqA9hjQLt 2bRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gCXsIkYFJ96Uz1VPwz9Vvmd2vwz/SWcd9QXP4jJQ8jw=; b=SLpPXl/hJeIU1K/W0IEvqAXnBblpoMPcK+MPrmkRvMpJQiCJ4ZbYSYxyEELbaA+mDC AP1XBZqN+ImPEWv31lHx0iNZxrZL3rZQeQAD7gCMhMJYKrXixfVBZHG6xHDMXm6O1O0e ZQ91YC2nK0l1OmDJhd8YYIgwPq8tOJ6SF0QShArkJtPa1ElYEmrFQqCmDWGXYCTHz3ok 0RxcG+KxfnEOiljZnvAX/gBeVyfSIZozQiMZSb3DahtwFpWAVk8KrEzWELtqW+tXTEOu 9AN4IwI52Y+S3klMbvBvyCoDUhXysMgfU1v0VHpAPsIHfbTmurDjxLfemBoCttifbgly dgBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YegHihmO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b47si7399026edc.45.2019.09.08.22.47.36; Sun, 08 Sep 2019 22:48:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YegHihmO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406260AbfIGRmg (ORCPT + 99 others); Sat, 7 Sep 2019 13:42:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:38130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728507AbfIGRmf (ORCPT ); Sat, 7 Sep 2019 13:42:35 -0400 Received: from localhost (unknown [80.251.162.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97BAF218AE; Sat, 7 Sep 2019 17:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567878155; bh=GHJAVT2/iebWv8cgiLcaT3iJsHValcnDCOHaDLgxd3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YegHihmOrO7HqZ8bbVS3tGIm+iTrMZL4wtxB3E9/+Q1wZcSR8euLNe94MGe7MNf40 6do0qipds9FaHV9diRE/V8AXcgsINqBopWBfhEuPMo5cn3kmDafSCK4Cp1F2f/jJ5/ A60rHL6eAzIF7SOOfAsEvG10E8lDZgWJCYnX5Olg= Date: Sat, 7 Sep 2019 18:42:32 +0100 From: Greg KH To: Sandro Volery Cc: linux-kernel@vger.kernel.org, jslaby@suse.com Subject: Re: [PATCH] Fixed most indent issues in tty_io.c Message-ID: <20190907174232.GA20070@kroah.com> References: <20190907172944.GB18166@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: > > > >>> On 7 Sep 2019, at 19:29, Greg KH wrote: > >> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote: > >> Dear Greg, > >> I am pretty sure the issue was, that I did too many things at once. However, all the things I did are related to spaces / tabs, maybe that still works? > > > > > > > > For some reason you sent this only to me, which is a bit rude to > > everyone else on the mailing list. I'll be glad to respond if you > > resend it to everyone. > > I'm sorry, newbie here. I thought it'd be better to not annoy everyone with responses but learning things everyday I guess :) No problem, but you should also line-wrap your emails :) > I am pretty sure the issue with my patch was that there was too many changes, however all of them were spaces and tabs related, so I think this could be fine? As the bot said, break it out into "one patch per logical change", and "fix all whitespace issues" is not "one logical change". thanks, greg k-h