Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3918891ybe; Mon, 9 Sep 2019 00:58:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1W3ctSfaxVdPFHLw05awDBKvQSzTZRjt88bvUDrNRXKInNxzj7YEQQEsZ2rMeV8fGC0Xo X-Received: by 2002:a17:906:529a:: with SMTP id c26mr18434048ejm.232.1568015881057; Mon, 09 Sep 2019 00:58:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568015881; cv=none; d=google.com; s=arc-20160816; b=mHB3So4EtGUHz4D3VRWRTH9xpIxuhH5y1fYcXLkMFvtvfErNqOpP6BLRFqMSNstCYE NOQiPRqbqqWbtLx/ig5B+QknVhnnjVLwgGcj1P4FV6EVlbpynf+ha2YM5Khg/+BgGyJ3 Yf7vIAfMCm/Oxp94aMLN1U58p/htHuQlwlRGddFt5jLnU8MwQBfObZTMvycqjU3Ch2wk lRTGTtY80ritToSCi7Ddv8cL2WFPBxL0bZv+eMV2rFRM6ROjVZvRvT93LUgLGOgU0sd7 KTd2ZA0g0cVpsAiRIxeZXqdzQBnxOEwCCi+5uVeGJpYpC3JBI2RG6SG5NZdjFWoJ2mcN 7j9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jljIIyAxCHxfSTikpTEvJGUX0bCUYZlkCKTu7DSTE6U=; b=kGkLy6iYTSimwBMbOY7pys8uUfcUnNU48GfeDhuWv3pgel0ZpeRkt6X/EoET3C6tID fa7ehiJTQ6XcvcTLjjttfv0E7aUbV4tuka26hRyiCC91E73BCSRQPflCjYyhqk2rYC0s sv59GlQlZ0ZmiWhphjzZY3nbdcssKUeqsw1Gkbf7hp8b3tt1uENzGDr2JMVpQ+PoCd1b rlQCrzXv6R9WFiDBPpDf7Q8rQgAEcJukC5pdBOoPuF5fa0GYbuXljMQeputbNC1/ujFt +gtWpcc9aVJzmsX1+EmODNaguErqrXq7mYiTSlUC2hS4P7/OhEy/LIwQQsC8kKgR8pTi /1og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ingics-com.20150623.gappssmtp.com header.s=20150623 header.b=Nx5VD1xK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i40si7747246eda.225.2019.09.09.00.57.37; Mon, 09 Sep 2019 00:58:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ingics-com.20150623.gappssmtp.com header.s=20150623 header.b=Nx5VD1xK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfIHDzS (ORCPT + 99 others); Sat, 7 Sep 2019 23:55:18 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:39285 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfIHDzR (ORCPT ); Sat, 7 Sep 2019 23:55:17 -0400 Received: by mail-pl1-f195.google.com with SMTP id bd8so4998589plb.6 for ; Sat, 07 Sep 2019 20:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jljIIyAxCHxfSTikpTEvJGUX0bCUYZlkCKTu7DSTE6U=; b=Nx5VD1xK8hbxrVE7cI9oGnidtGTfB753yAbOvW+3U98smXbwwEee7gjXb7/zbw6N0j guFclXcjzgXW1XBuZz+MExbHq5/29G6u1E2J58wuKXQwgKcogTjIzCdV1ynnEb4FOtPw M7df3v+500Igv403XJCcmR2Svh5tccepefodLxGcV2NRbOJJvBOJt/WpXy25BsKBamkv qpeeTEk081RUDNoL1bQJlvzgsT2Pv7HeKQXj8Kaf0bffd+fnx01grTUc4mvs32hvm9U9 W12NFQbYNyTj8biYOYWKxsuBaZ760piCj2QMdJafE4Lf9ueeil2vyVslDQ4zVA/MzKRd gKwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jljIIyAxCHxfSTikpTEvJGUX0bCUYZlkCKTu7DSTE6U=; b=jTohG6BiyYVrfAeCDqxXjlAb2vWs2GEca9d2MZ9L+jJTQef4Nt21ghavOZb3qRCZ1N RPUj1ebBAT2Nn7bRSJY3PyZUgbUAY5FupvoK24acMKZOAAGzJjGE47kj7NrmZXwUSxd6 l9H+2P4H7psggjBg6zt7UP+ogI1Sy76K0hkqHHT/TgXjLUK+RA/+f80uMGBvMlql7kjO tSEpLt/c0v7Nx1b+IJCIZZ7vzLMt/km25EmN/qhpWkw0+z4X2yA0AunWvIp5vCvTy+Ng 9RQgCN4TRrcAR7U/qtiEbQ5k0sXxtxwmtMZ6z/fSRRsxtFWx3ytaX92tECj7CViOpaFJ LnUg== X-Gm-Message-State: APjAAAUuchPaxx79KyCBaT3s0gX72qQLnusJ7lMmqGWP3/WWChlG9tVJ uc+a89eoUDPbsaDhcH0ezEyuWg== X-Received: by 2002:a17:902:9f8c:: with SMTP id g12mr6348347plq.326.1567914916822; Sat, 07 Sep 2019 20:55:16 -0700 (PDT) Received: from localhost.localdomain (122-117-179-2.HINET-IP.hinet.net. [122.117.179.2]) by smtp.gmail.com with ESMTPSA id j9sm10634657pfi.128.2019.09.07.20.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Sep 2019 20:55:16 -0700 (PDT) From: Axel Lin To: Mark Brown Cc: Keerthy , Liam Girdwood , linux-kernel@vger.kernel.org, Axel Lin Subject: [PATCH] regulator: Simplify lp87565_buck_set_ramp_delay Date: Sun, 8 Sep 2019 11:55:06 +0800 Message-Id: <20190908035506.17611-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use rdev->regmap/&rdev->dev instead of lp87565->regmap/lp87565->dev. In additional, the lp87565->dev actually is the parent mfd device, so the dev_err message is misleading here with lp87565->dev. Signed-off-by: Axel Lin --- drivers/regulator/lp87565-regulator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c index 0c440c5e2832..4ae12ac1f4c6 100644 --- a/drivers/regulator/lp87565-regulator.c +++ b/drivers/regulator/lp87565-regulator.c @@ -65,7 +65,6 @@ static int lp87565_buck_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) { int id = rdev_get_id(rdev); - struct lp87565 *lp87565 = rdev_get_drvdata(rdev); unsigned int reg; int ret; @@ -86,11 +85,11 @@ static int lp87565_buck_set_ramp_delay(struct regulator_dev *rdev, else reg = 0; - ret = regmap_update_bits(lp87565->regmap, regulators[id].ctrl2_reg, + ret = regmap_update_bits(rdev->regmap, regulators[id].ctrl2_reg, LP87565_BUCK_CTRL_2_SLEW_RATE, reg << __ffs(LP87565_BUCK_CTRL_2_SLEW_RATE)); if (ret) { - dev_err(lp87565->dev, "SLEW RATE write failed: %d\n", ret); + dev_err(&rdev->dev, "SLEW RATE write failed: %d\n", ret); return ret; } -- 2.20.1