Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4246223ybe; Mon, 9 Sep 2019 06:34:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSKVTpgH5G/fPYA3QcPc7D7MstOAkw9+1wC1NCtk1LQHTzjNgsI4YmAN3uP/JWeabBltMM X-Received: by 2002:a17:906:6810:: with SMTP id k16mr19349238ejr.193.1568036053599; Mon, 09 Sep 2019 06:34:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568036053; cv=none; d=google.com; s=arc-20160816; b=lpv+O/YnjVLMMgD5/0CbB6A7Yp4wQjjucQXRqu3OdQP0jrOLi1MAinU9Z6Lqjh461q Wtm0UQ0XuUR2dNTt01soWLxYI/QcZF+HjNDHZngUiDTSBQfTLPituCUBwFeUix1Txb48 hM2bRj87h4ciAOHvD8jckeay4M+v4JGauguMfE0O31iHrLTrZC9+153oP1nrPIyvH+uA Ro59N9ffAjiACBewdbRi2YJNWYHUKDTg3mmtI8ZrmlEuR5ert8qx4p0+6FrMMwG+Edvm gcDmw4tPvQDCZir1Dh3hwDYdI76ZL3s2TJ3n3yAJrrHUcDU7RyMCFqrLPLCWSZc0G6Bj 8WXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=TuHIWFdcsxUJqPswaYj4b0GivTB6Jcoizn7SrmAv+OI=; b=ogE/2YWKUIqE/OSKA0AT6Ntj6t3pkRjRwCGbSLlx1mLOtRRkPHWQlANWIruvIllIcn rb5wmFOnJspQhBBpsMoK2cB4GlCIBg4FOh0RS20kicaSGB2v6g6b3g7bhZmkq9sRpmre byMMNkfWhvOdWIAzztbe/fguWSS583KlcBtE+4gTVlMS+RzCoEvRJkyEATn/YdSx7pNo Zce4Hu4uHwBxXb92Zc1YG6WRDmeUezeCM8lORUxnDwIcujp4zc89DPfg/FXJs9vDrWF+ g0OwH97NNDP/qBZVrPdnWiMiAv4rjil22mhrlRggXfqCVCNAi6kl16EJX147eJpmBk9j sH0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=hpbl52co; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pg9si7452936ejb.9.2019.09.09.06.33.49; Mon, 09 Sep 2019 06:34:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=hpbl52co; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729061AbfIHUH2 (ORCPT + 99 others); Sun, 8 Sep 2019 16:07:28 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:45472 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728974AbfIHUH1 (ORCPT ); Sun, 8 Sep 2019 16:07:27 -0400 Received: by mail-lf1-f66.google.com with SMTP id r134so8809100lff.12 for ; Sun, 08 Sep 2019 13:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TuHIWFdcsxUJqPswaYj4b0GivTB6Jcoizn7SrmAv+OI=; b=hpbl52co8tDUVi/7gHuODZirz/kPjg5s1T3Nnm+ujNoC3UW8LeJuFgjmu/QfpDpg6F 9KL5/fR9vyl6YVuwMxlmHCaPhitd5He6n/wXCO+wtNHY8gG9J6M+aOF6ofQwA0cxvSgq xJwLdoNj8/+6d4ae319EYmqQyKdMAiDOnk8BdDMr4nPvyOQ4Y3VurcTOljU1a63qoKOc OfzWgjijnGzIXdF0CBAxxaDM3F1mQnCu8BDmc82CqiVRB5AJ5YbcaRruZUOgs4HnWeKe YZZWUzgDTPEfUWlQjZsBLu/seUOX81ornseYt+nkA4KJ8zLa7vLu9/GQyej9jXErdvfZ Rf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TuHIWFdcsxUJqPswaYj4b0GivTB6Jcoizn7SrmAv+OI=; b=adbvppcLeHmn1/xXYThTt535PtBBAtA7U4SjSkOtrKQJFyMORllnCeG3G2so08bQj6 AbcFJsl4rubEXZ+4pBIvS6lIL9bNNRc9Gqkzr3jtHtOA2kfNQQY+LMoAFq3ZVa0H1xTX zPzv1dIhCHcgGLpTE1ebF4dmediDolf4LxoR/8KVeFDcc6Nw/yt/bJQzx+32Q1S9EY4y Hh/nmSqq11Uc1NXQHDq7t5cMLJg928RMPN/GQKzR/YI5NkEBKnX1jMXBKC/gL+2Aee5y 9/8ID5frIp7VW95eHmJdtIV4ADyCJdCk3EX0bsaEh7EfNkD3/fJ+z+9pFEAsFlfALsnf e5Nw== X-Gm-Message-State: APjAAAWWCXGyOWSQJExKX5BQ3lPXpJm5tpFv8N9FlnppzQkNut/WANvW F2i42zh2DtcJM8eWzXSE9Ls/T23LiTnS1zx2jLl99w== X-Received: by 2002:ac2:4352:: with SMTP id o18mr14106857lfl.164.1567973244230; Sun, 08 Sep 2019 13:07:24 -0700 (PDT) MIME-Version: 1.0 References: <20190628033413.8058-1-rajatja@google.com> In-Reply-To: From: Rajat Jain Date: Sun, 8 Sep 2019 13:06:47 -0700 Message-ID: Subject: Re: [PATCH v7] platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1" To: Andy Shevchenko Cc: Rajneesh Bhardwaj , Vishwanath Somayaji , Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List , Rafael J Wysocki , Srinivas Pandruvada , Furquan Shaikh , Evan Green , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 7, 2019 at 10:42 AM Andy Shevchenko wrote: > > On Fri, Aug 23, 2019 at 1:44 AM Rajat Jain wrote: > > > > On Thu, Jun 27, 2019 at 8:34 PM Rajat Jain wrote: > > > > > > Most modern platforms already have the ACPI device "INT33A1" that could > > > be used to attach to the driver. Switch the driver to using that and > > > thus make the intel_pmc_core.c a pure platform_driver. > > > > > > Some of the legacy platforms though, may still not have this ACPI device > > > in their ACPI tables. Thus for such platforms, move the code to manually > > > instantiate a platform_device into a new file of its own. This would > > > instantiate the intel_pmc_core platform device and thus attach to > > > the driver, if the ACPI device for the same ("INT33A1") is not present > > > in a system where it should be. This was discussed here: > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1966991.html > > > > > > HI Andy, Rajneesh, this seems to have fallen through the cracks. Any > > comments here on this patch? > > % git tag --list v5.3* --contains b02f6a2ef0a1 > v5.3-rc1 Oops, my apologies, I failed to notice it. Thanks, Rajat > > -- > With Best Regards, > Andy Shevchenko