Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Sep 2019 11:18:10 +0100
From:   Sebastian Reichel <sre@kernel.org>
To:     Nandor Han <nandor.han@vaisala.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        kbuild test robot <lkp@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: core: fix nvmem_cell_write inline function
Message-ID: <20190909101810.gtqouke7vyu63r7e@earth.universe>
References: <20190908121038.6877-1-sre@kernel.org>
 <d5017670-5622-283e-1376-8161d6e39dcd@vaisala.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qss4xo2ixrxhdmym"
Content-Disposition: inline
In-Reply-To: <d5017670-5622-283e-1376-8161d6e39dcd@vaisala.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qss4xo2ixrxhdmym
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Sep 09, 2019 at 12:26:06PM +0300, Nandor Han wrote:
> On 9/8/19 3:10 PM, Sebastian Reichel wrote:
> > From: Sebastian Reichel <sebastian.reichel@collabora.com>
> >=20
> > nvmem_cell_write's buf argument uses different types based on
> > the configuration of CONFIG_NVMEM. The function prototype for
> > enabled NVMEM uses 'void *' type, but the static dummy function
> > for disabled NVMEM uses 'const char *' instead. Fix the different
> > behaviour by always expecting a 'void *' typed buf argument.
> >=20
> > Fixes: 7a78a7f7695b ("power: reset: nvmem-reboot-mode: use NVMEM as reb=
oot mode write interface")
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Cc: Han Nandor <nandor.han@vaisala.com>
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >   include/linux/nvmem-consumer.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consu=
mer.h
> > index 8f8be5b00060..5c17cb733224 100644
> > --- a/include/linux/nvmem-consumer.h
> > +++ b/include/linux/nvmem-consumer.h
> > @@ -118,7 +118,7 @@ static inline void *nvmem_cell_read(struct nvmem_ce=
ll *cell, size_t *len)
> >   }
> >   static inline int nvmem_cell_write(struct nvmem_cell *cell,
> > -				    const char *buf, size_t len)
> > +				   void *buf, size_t len)
>=20
> nitpick: alignment issue?

This actually fixes the alignment issue as a side-effect.
I guess I should have mentioned it in the changelog.

> Review-By: Han Nandor <nandor.han@vaisala.com>

I suppose you meant to write "Reviewed-by" instead of inventing your
own tag?

-- Sebastian

--qss4xo2ixrxhdmym
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl12JtgACgkQ2O7X88g7
+pq+5w//WFTsXR9hQ39fHiyVSsAdYdKNBuhCXUY94CzlZceJYrRB9YwbTP4lInFF
bTgIrC3myS3qLqEcXEpXOdZZmAw/Y7FjQFDSXaAia8NLOQiBiwhVRPcWKCxk1jKS
rHm2TIWPnTavtzQLI6m3xEcTpodfyYCrTVGRS12jNhQEokzuLrxEgP5xxX1d2KxT
esYmPbnOyW95kzLhoHk0Wt1gq7AXDM0xc0HbKxGuyrHFfmwOBEQiIGlZwAjvrIIL
ZD/EBfye7hNSAArgFz8ynehrj9vyxGPYUj7msIZYSk2u901MG7IaOVZpBYV9VBLe
CDk+uN/klWJlbBFeV9IMJ4nzgX5H1Rm2iuJ/hMZVcLe8s00IsgDhDOPBfbPlTjVx
IBZJMXog/ZQJxBsSycTPuT3swLRHvPQwnHjjxJYn6DkJYgY2xaBDwa/3d7t2FZvv
a02mT3t+AWqylKACzEYuAN/1xCEwJAhLuJACn2YXKtj0J5kOzBxcg4Y8ViW4NEJX
AFG7nqQ61hKhA0vljqUaWZDcfnNBM0szNISMqkd10YaOqBMRuUMATWsHr8cwd4L9
28ESIUYSBiapWFoPQByyq/plM25uhU3wCQ3oBqHsZE0cAoMzUE89qLMy9KFXoyvK
EYaznGEjO2JeRk/dJXgGt8gJD1Wh9nm4XiNtbmCzUUwFPL0Gd+k=
=5KCd
-----END PGP SIGNATURE-----

--qss4xo2ixrxhdmym--