Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4849104ybe; Mon, 9 Sep 2019 15:57:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqykiV9t9M3RU/aIkIk9Ckdb4aSAYt08K5buxYF66icAl+E0K/RqBB26HQSSCIcRrmC63Z6q X-Received: by 2002:a17:906:4f0e:: with SMTP id t14mr21145188eju.47.1568069879551; Mon, 09 Sep 2019 15:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568069879; cv=none; d=google.com; s=arc-20160816; b=CIjQ4y+qnQJS/gKHbjLUmPUGO/JCFR2blMe+8b0Q6EL5KFCns5DJDQfFX8fwn8UDre Hnihh1WC1aPoPZJr9UUV4zDKMf9iCbiHflj9r7whcY5WzgrSQHzvWIW27PK0KBakbZnE EiNDzuZpsAuLVkD4mL+Xg/11yl/8MejKtuD6zckN9fhqZBsLJNyoQisfe7b4EkDVxj/a /S9B1XhqxWEOYSKOWFn9Rko4O4kqS0k8ysVK81oGvGhGtn1n2XiIBpk/SsedW2ge4t5P FnQ1EOXcgggwLW6U5TnY/TUJEB5ZcZDtbrVqNGDg5bKlwy7cK9gj2m0CzLz095QlA5P9 J9VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cC4g9BRBEaf08E8q7Ceq+EDE6JFex4JwlziqyOjWmy0=; b=u12RSF5YXnzz/0rCpcVI3X3t3eNMFdunTMiDfDsDdSdbtCTgHmXKMk9aMy4zW+VlgG 7/0aD3T5mQPsZf+prP/ZrObxPcTXopEGBPr0uEX8n/EUU+fBRQdruPkD/3cc2uv4bnKn Ywxuy7zLYfL1r4aJ84wjyqf2qXY6E39gISDLcGvn9drzpNl32czBMlI8PA7BcClW9QTZ jF4OJLl+DVkVaWdkaR053OnruGYxgMGlhWdgPsDcOdJPMr4rVKUbLuRtbJNsZJdNWlNq YafzJexkg8lRjWSngpKJW1vIZsdqdG4xHWe4UxZhQ/VgL9eK2K1IfGil+FC2TwxoU/hz dDww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PVIe3K3q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16si6208245eje.248.2019.09.09.15.57.35; Mon, 09 Sep 2019 15:57:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PVIe3K3q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390872AbfIIK7r (ORCPT + 99 others); Mon, 9 Sep 2019 06:59:47 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40383 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390755AbfIIK7q (ORCPT ); Mon, 9 Sep 2019 06:59:46 -0400 Received: by mail-wm1-f67.google.com with SMTP id t9so14102822wmi.5 for ; Mon, 09 Sep 2019 03:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cC4g9BRBEaf08E8q7Ceq+EDE6JFex4JwlziqyOjWmy0=; b=PVIe3K3q+MLvV9INLxU2fZYlQCC9Jc1EePTFLZast77owUaVemUSI1wYrcz+h1thcT /DU/8gPgn0DHHXvoBNfU9oEobDMKs3QGwxbmVTSpJl6oZaSDoJyZpnsiqcT945v+w/fz mJDJtD8l/7MHSRYQppq1Jdi+Z4kY06oBD/kg65+/MCD/YmxvzjTJ7gD/H7xy0vmBXiz1 FP6c9+wIoz5/qyhzC5+uqESbx88b4zOeFtyaNfkWBrnRvGaoNVd01IgGSmUs93HKYmfU xbV7YqOoRdRUq9LLJv9mbAvGCpjbkOfC63THV2N7eFR5xusJYYpO+yQpmy5HKDgAakji ORYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cC4g9BRBEaf08E8q7Ceq+EDE6JFex4JwlziqyOjWmy0=; b=krSZGKtHWEt7ypRi6SBFdUM2rkKGSc8PZfxoIcvcpEkn0ALSpVs7FJ13gI1ijFt9OT iZ5hnsV5ZuUT3tLfzWz4DoOAV/qvVZpyOquT1ZTIb/u3PK+GwAD2xfl4hWKx/waPhkD2 qkyQRhnpDsJKhFLRFoOXf7/68ttGLrGeyAG1rsFML7KZ0RwTNf+vOUNf+8DOj+Yk27y7 +l7O6rYmXr4Mf0AStYAeFrfKJuPDZXuDLPRtN6kBbJ6gpQRODXQCN+Kyo+v1n8dWY5V5 VgsZKgBBZ6Ia8PE8ySVxZjc0MJ29KywovvAI2IvL3xSA2RWpnAqQAV6sLGBPNI6SSOtz FWjw== X-Gm-Message-State: APjAAAWSTCpK2E9i3QV3cUenjuFriL91qWedCtu0tOngjK7GdX91F4EF vB60/mYq7zQL94Aw7WDIO3RKqg== X-Received: by 2002:a05:600c:2105:: with SMTP id u5mr155367wml.150.1568026784923; Mon, 09 Sep 2019 03:59:44 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id s3sm10943664wmj.48.2019.09.09.03.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2019 03:59:44 -0700 (PDT) Date: Mon, 9 Sep 2019 11:59:42 +0100 From: Daniel Thompson To: Andreas Kemnade Cc: lee.jones@linaro.org, jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, "H. Nikolaus Schaller" Subject: Re: [PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios Message-ID: <20190909105942.pxwz6rtjg3cxlcnf@holly.lan> References: <20190908203704.30147-1-andreas@kemnade.info> <20190908203704.30147-3-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190908203704.30147-3-andreas@kemnade.info> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 08, 2019 at 10:37:04PM +0200, Andreas Kemnade wrote: > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade Looks like patches are in the wrong order. Changes to bindings must appear in patchsets *before* the Linux implementation of the bindings. > --- > .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..a9656d72b668 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg Please add enable-gpios to one of the examples. Daniel.