Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4954442ybe; Mon, 9 Sep 2019 18:02:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxktDE4wXjflUVLFUL0e+UiSMGzWFuU1Bb2nmscrIF7wX6bva8Og+G/1xLKRh2zOa6Kksw X-Received: by 2002:a17:906:f282:: with SMTP id gu2mr22195661ejb.198.1568077321679; Mon, 09 Sep 2019 18:02:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568077321; cv=none; d=google.com; s=arc-20160816; b=bbaWvg+bNKmWBkOqyHWi2y9eCnwT/k6n+KU/XKCpU85t79cJt7tK4MJmi9JdLXNflQ 84TrKVcODgSkMj0KY+PiNNX6u2fF3l8nlpoX4OGRYw2eU9x74On4M4Fb5neZ2eoVrVtS lXSJxzic19AD/Zn9WVCzP8BP2nHZetORsEKNqradmXd2hv1rR3irq5ULsnsUvlJcTExJ nasEHR9hRMV4I4xpCXeO3eMe0Dt7vI6dQZJUA7D9RTa0L1x1Zs6ZeoAhrNNWMDBT5noA lbSJKGpWxLkCvHcxWGlr1yynb7QP99uwczAJ7xYMlGiF2Bl8ZKeoNM+bSyFM4mTxb660 JQug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=V2wEq4f6XStLIDjokqWVitxPkSCjY6p1gEXfw5+NDbA=; b=g+WxVDaRFX7T/oOOlJtEB9GTAG+6vdMb4G5ygEPryuja1XJh1rBBr6SlYXlQ+aIlyn AnLb/0TwyP+8iPBWDuI14xt6LnL1cnAoHgHCWNutOQs+BNNQoam2l2ys01qbbdG1GMel KJfvGsDY+TgFWHC4cVsVEtNuY8sqgBEJrLDT7CiDGhP0hVrDyhBZtTiICzxj+gsqbDs0 2fLUq5tIriBuKOYVyFoVHVUaTGlr+b8bak0tMX0hl/pu0cdjAmEsZFR+MydTFPZv98pu 0gvXz8RmneSxjGaIMUDATwhIQpudgHwHI7MgE7NJx/It+dfVijM80KdWKULdXaXhP1wV WckA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23si2372781ejj.367.2019.09.09.18.01.37; Mon, 09 Sep 2019 18:02:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404629AbfIIMCr (ORCPT + 99 others); Mon, 9 Sep 2019 08:02:47 -0400 Received: from mga06.intel.com ([134.134.136.31]:24341 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404470AbfIIMCq (ORCPT ); Mon, 9 Sep 2019 08:02:46 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 05:02:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="383954631" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.66]) ([10.237.72.66]) by fmsmga005.fm.intel.com with ESMTP; 09 Sep 2019 05:02:42 -0700 Subject: Re: [PATCH 2/4] mmc: Add virtual command queue support To: Baolin Wang , ulf.hansson@linaro.org, riteshh@codeaurora.org, asutoshd@codeaurora.org Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, arnd@arndb.de, linus.walleij@linaro.org, vincent.guittot@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <14599f7165f23db2bf7b71a2596e808e2bc2056c.1567740135.git.baolin.wang@linaro.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <3bcd69fd-2f8e-9b87-7292-4b0b1aa5be78@intel.com> Date: Mon, 9 Sep 2019 15:01:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <14599f7165f23db2bf7b71a2596e808e2bc2056c.1567740135.git.baolin.wang@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/09/19 6:52 AM, Baolin Wang wrote: > Now the MMC read/write stack will always wait for previous request is > completed by mmc_blk_rw_wait(), before sending a new request to hardware, > or queue a work to complete request, that will bring context switching > overhead, especially for high I/O per second rates, to affect the IO > performance. > > Thus this patch introduces virtual command queue interface, which is > similar with the hardware command queue engine's idea, that can remove > the context switching. CQHCI is a hardware interface for eMMC's that support command queuing. What you are doing is a software issue queue, unrelated to CQHCI. I think you should avoid all reference to CQHCI i.e. call it something else.