Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190826164510.6425-2-jorge.ramirez-ortiz@linaro.org>
References: <20190826164510.6425-1-jorge.ramirez-ortiz@linaro.org> <20190826164510.6425-2-jorge.ramirez-ortiz@linaro.org>
Cc:     bjorn.andersson@linaro.org, niklas.cassel@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     agross@kernel.org, jorge.ramirez-ortiz@linaro.org,
        mturquette@baylibre.com
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT
User-Agent: alot/0.8.1
Date:   Mon, 09 Sep 2019 03:23:54 -0700
Message-Id: <20190909102354.D60252089F@mail.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jorge Ramirez-Ortiz (2019-08-26 09:45:07)
> @@ -61,6 +63,16 @@ static int qcom_apcs_msm8916_clk_probe(struct platform=
_device *pdev)
>         if (!a53cc)
>                 return -ENOMEM;
> =20
> +       /* legacy bindings only defined the pll parent clock (index =3D 0=
) with no

Another nitpick: This is wrong multi-line comment style. SHould be a
bare /* on this line.

> +        * name; when both of the parents are specified in the bindings, =
the
> +        * pll is the second one (index =3D 1).
> +        */