Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v3 0/9] hacking: make 'kernel hacking' menu better
 structurized
To:     Changbin Du <changbin.du@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
References: <20190909144453.3520-1-changbin.du@gmail.com>
Message-ID: <da2774e1-fc41-0dde-01ed-0607920ce762@infradead.org>
Date:   Mon, 9 Sep 2019 09:53:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190909144453.3520-1-changbin.du@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/9/19 7:44 AM, Changbin Du wrote:
> This series is a trivial improvment for the layout of 'kernel hacking'
> configuration menu. Now we have many items in it which makes takes
> a little time to look up them since they are not well structurized yet.
> 
> Early discussion is here:
> https://lkml.org/lkml/2019/9/1/39
> 
> This is a preview:
> 
>   │ ┌─────────────────────────────────────────────────────────────────────────┐ │  
>   │ │        printk and dmesg options  --->                                   │ │  
>   │ │        Compile-time checks and compiler options  --->                   │ │  
>   │ │        Generic Kernel Debugging Instruments  --->                       │ │  
>   │ │    -*- Kernel debugging                                                 │ │  
>   │ │    [*]   Miscellaneous debug code                                       │ │  
>   │ │        Memory Debugging  --->                                           │ │  
>   │ │    [ ] Debug shared IRQ handlers                                        │ │  
>   │ │        Debug Oops, Lockups and Hangs  --->                              │ │  
>   │ │        Scheduler Debugging  --->                                        │ │  
>   │ │    [*] Enable extra timekeeping sanity checking                         │ │  
>   │ │        Lock Debugging (spinlocks, mutexes, etc...)  --->                │ │  
>   │ │    -*- Stack backtrace support                                          │ │  
>   │ │    [ ] Warn for all uses of unseeded randomness                         │ │  
>   │ │    [ ] kobject debugging                                                │ │  
>   │ │        Debug kernel data structures  --->                               │ │  
>   │ │    [ ] Debug credential management                                      │ │  
>   │ │        RCU Debugging  --->                                              │ │  
>   │ │    [ ] Force round-robin CPU selection for unbound work items           │ │  
>   │ │    [ ] Force extended block device numbers and spread them              │ │  
>   │ │    [ ] Enable CPU hotplug state control                                 │ │  
>   │ │    [*] Latency measuring infrastructure                                 │ │  
>   │ │    [*] Tracers  --->                                                    │ │  
>   │ │    [ ] Remote debugging over FireWire early on boot                     │ │  
>   │ │    [*] Sample kernel code  --->                                         │ │  
>   │ │    [*] Filter access to /dev/mem                                        │ │  
>   │ │    [ ]   Filter I/O access to /dev/mem                                  │ │  
>   │ │    [ ] Additional debug code for syzbot                                 │ │  
>   │ │        x86 Debugging  --->                                              │ │  
>   │ │        Kernel Testing and Coverage  --->                                │ │  
>   │ │                                                                         │ │  
>   │ │                                                                         │ │  
>   │ └─────────────────────────────────────────────────────────────────────────┘ │  
>   ├─────────────────────────────────────────────────────────────────────────────┤  
>   │          <Select>    < Exit >    < Help >    < Save >    < Load >           │  
>   └─────────────────────────────────────────────────────────────────────────────┘ 
> 
> v3:
>   o change subject prefix.
> v2:
>   o rebase to linux-next.
>   o move DEBUG_FS to 'Generic Kernel Debugging Instruments'
>   o move DEBUG_NOTIFIERS to 'Debug kernel data structures'
> 
> Changbin Du (9):
>   hacking: Group sysrq/kgdb/ubsan into 'Generic Kernel Debugging
>     Instruments'
>   hacking: Create submenu for arch special debugging options
>   hacking: Group kernel data structures debugging together
>   hacking: Move kernel testing and coverage options to same submenu
>   hacking: Move Oops into 'Lockups and Hangs'
>   hacking: Move SCHED_STACK_END_CHECK after DEBUG_STACK_USAGE
>   hacking: Create a submenu for scheduler debugging options
>   hacking: Move DEBUG_BUGVERBOSE to 'printk and dmesg options'
>   hacking: Move DEBUG_FS to 'Generic Kernel Debugging Instruments'
> 
>  lib/Kconfig.debug | 659 ++++++++++++++++++++++++----------------------
>  1 file changed, 340 insertions(+), 319 deletions(-)

Hi,
Looks good to me.

I verified that the before and after kernel .config file contains the same
symbols and values (for allmodconfig).
I also tested with menuconfig, nconfig, gconfig, and xconfig.

for all 9 patches:
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.
-- 
~Randy