Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Sep 2019 12:14:57 -0500
From:   Benoit Parrot <bparrot@ti.com>
To:     Joe Perches <joe@perches.com>
CC:     Hans Verkuil <hverkuil@xs4all.nl>,
        Prabhakar Lad <prabhakar.csengg@gmail.com>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 09/13] media: am437x-vpfe: fix function trace debug log
Message-ID: <20190909171457.louslicqvyv4vpde@ti.com>
References: <20190909162743.30114-1-bparrot@ti.com>
 <20190909162743.30114-10-bparrot@ti.com>
 <ec66e477095bcddb86ffcc7ca10d3e0bbe72f943.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ec66e477095bcddb86ffcc7ca10d3e0bbe72f943.camel@perches.com>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Joe Perches <joe@perches.com> wrote on Mon [2019-Sep-09 09:54:56 -0700]:
> On Mon, 2019-09-09 at 11:27 -0500, Benoit Parrot wrote:
> > checkpatch.pl nows reports several:
> > WARNING: Prefer using '"%s...", __func__' to using '<function name>',
> > this function's name, in a string
> > 
> > So fix these for the whole driver.
> 
> Most of these seem to be function tracing comments
> that should probably be removed instead.
> 
> The generic kernel facility ftrace works well.

Yeah you are probably right, I should just remove them.
My own laziness prevented me earlier... it's always easier to just enable
debug dynamically in the driver then trying to remember how to use ftrace :)
I obviously don't use often enough.

Benoit

> 
> > diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> []
> > @@ -466,7 +466,7 @@ static void vpfe_ccdc_config_ycbcr(struct vpfe_ccdc *ccdc)
> >  	struct ccdc_params_ycbcr *params = &ccdc->ccdc_cfg.ycbcr;
> >  	u32 syn_mode;
> >  
> > -	vpfe_dbg(3, vpfe, "vpfe_ccdc_config_ycbcr:\n");
> > +	vpfe_dbg(3, vpfe, "%s:\n", __func__);
> 
> Remove this instead
> 
> >  	/*
> >  	 * first restore the CCDC registers to default values
> >  	 * This is important since we assume default values to be set in
> > @@ -598,7 +598,7 @@ static void vpfe_ccdc_config_raw(struct vpfe_ccdc *ccdc)
> >  	unsigned int syn_mode;
> >  	unsigned int val;
> >  
> > -	vpfe_dbg(3, vpfe, "vpfe_ccdc_config_raw:\n");
> > +	vpfe_dbg(3, vpfe, "%s:\n", __func__);
> 
> here too, etc...
> 
>