Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Pengfei Li <lpf.vector@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "vbabka@suse.cz" <vbabka@suse.cz>, "cl@linux.com" <cl@linux.com>,
        "penberg@kernel.org" <penberg@kernel.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] mm, slab_common: Make 'type' is enum
 kmalloc_cache_type
Thread-Topic: [PATCH v2 3/4] mm, slab_common: Make 'type' is enum
 kmalloc_cache_type
Thread-Index: AQHVZzE0SUuLIOWnuUe4DGQG2id7Facjw+qA
Date:   Mon, 9 Sep 2019 20:00:00 +0000
Message-ID: <20190909195955.GA2181@tower.dhcp.thefacebook.com>
References: <20190909170715.32545-1-lpf.vector@gmail.com>
 <20190909170715.32545-4-lpf.vector@gmail.com>
In-Reply-To: <20190909170715.32545-4-lpf.vector@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::1:2b5d]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9f1cbd64-0437-41fb-9cd7-08d735604bbf
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BN8PR15MB2947;
x-ms-traffictypediagnostic: BN8PR15MB2947:
x-microsoft-antispam-prvs: <BN8PR15MB2947250E78CD973EC4B07D11BEB70@BN8PR15MB2947.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:534;
x-forefront-prvs: 01559F388D
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(346002)(376002)(396003)(136003)(366004)(189003)(199004)(229853002)(14444005)(54906003)(316002)(46003)(478600001)(6506007)(305945005)(7736002)(386003)(4326008)(186003)(256004)(1076003)(33656002)(6246003)(99286004)(76176011)(8676002)(2906002)(52116002)(9686003)(81156014)(81166006)(6512007)(53936002)(8936002)(6916009)(66446008)(64756008)(66556008)(66476007)(66946007)(446003)(6436002)(6116002)(86362001)(6486002)(5660300002)(14454004)(71190400001)(71200400001)(102836004)(25786009)(476003)(11346002)(486006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB2947;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: zpAanssIGGp+bGyFCNGrJe8UXY7mdhS8JtaZKUlJBkREAa6cmeI3SL+m5qjowCLEBzPkAvdBRLmRAJj5S1Dtc9L1rp9x5zd0dLRE/r0+iAKbiAQ+C0fwgkhcRswH33UeseRcDDTXE8G3k+u9PC9dwW6X7CaHHYy31XmuQLjzWYXXwb1Ja8SdLRxuDU6JnqfqdFO9ek7DnElkghl+qe4hwxAivjpmxU4f9NUN7biKw4+CGOuPe4nd9XstErpTJ0n5EL5vAH1fVYOftEuYPQ4PNJyzZ2enwQt9lBhGO2WMaZ1FfKKh6KOqPn3IpgUckDreBv5PAtsDiTAlDcPjoTX6NPCPoeetZSnp2p4trg+PwCBmJ+QMuu6nHKWgYWbc2qLI/pcAPjqGZdJwv1ppacMaRFIfI2fLCQj14tYH85uQTJM=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <153F3585B42C304694B3B0667164B592@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1cbd64-0437-41fb-9cd7-08d735604bbf
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2019 20:00:00.2114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 77njtViFhNLDLEkJP6otBl15B3x/EjAovW7ff+4j/WSFXHcm1OhuaxysymFnmwv0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2947
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-09_07:2019-09-09,2019-09-09 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=999
 clxscore=1011 phishscore=0 adultscore=0 suspectscore=0 priorityscore=1501
 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1906280000 definitions=main-1909090197
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 10, 2019 at 01:07:14AM +0800, Pengfei Li wrote:

Hi Pengfei!

> The 'type' of the function new_kmalloc_cache should be
> enum kmalloc_cache_type instead of int, so correct it.

I think you mean type of the 'i' variable, not the type of
new_kmalloc_cache() function. Also the name of the patch is
misleading. How about
mm, slab_common: use enum kmalloc_cache_type to iterate over kmalloc caches=
 ?
Or something like this.

The rest of the series looks good to me.

Please, feel free to use
Acked-by: Roman Gushchin <guro@fb.com>
for patches [1-3] in the series after fixing this commit message and
restoring __initconst.

Patch [4] needs some additional clarifications, IMO.

Thank you!

>=20
> Signed-off-by: Pengfei Li <lpf.vector@gmail.com>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>


> ---
>  mm/slab_common.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index cae27210e4c3..d64a64660f86 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1192,7 +1192,7 @@ void __init setup_kmalloc_cache_index_table(void)
>  }
> =20
>  static void __init
> -new_kmalloc_cache(int idx, int type, slab_flags_t flags)
> +new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t fl=
ags)
>  {
>  	if (type =3D=3D KMALLOC_RECLAIM)
>  		flags |=3D SLAB_RECLAIM_ACCOUNT;
> @@ -1210,7 +1210,8 @@ new_kmalloc_cache(int idx, int type, slab_flags_t f=
lags)
>   */
>  void __init create_kmalloc_caches(slab_flags_t flags)
>  {
> -	int i, type;
> +	int i;
> +	enum kmalloc_cache_type type;
> =20
>  	for (type =3D KMALLOC_NORMAL; type <=3D KMALLOC_RECLAIM; type++) {
>  		for (i =3D KMALLOC_SHIFT_LOW; i <=3D KMALLOC_SHIFT_HIGH; i++) {
> --=20
> 2.21.0
>=20
>=20