Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] x86/umip: Add emulation for 64-bit processes
From:   Brendan Shanks <bshanks@codeweavers.com>
In-Reply-To: <20190907212610.GA30930@ranerica-svr.sc.intel.com>
Date:   Mon, 9 Sep 2019 15:34:28 -0700
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        "Eric W. Biederman" <ebiederm@xmission.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <317243DA-3BAE-4620-8E31-5F23145DD992@codeweavers.com>
References: <20190905232222.14900-1-bshanks@codeweavers.com>
 <20190907212610.GA30930@ranerica-svr.sc.intel.com>
To:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Sep 7, 2019, at 2:26 PM, Ricardo Neri =
<ricardo.neri-calderon@linux.intel.com> wrote:
>=20
> On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote:
>>=20
>> 	if (umip_inst =3D=3D UMIP_INST_SGDT || umip_inst =3D=3D =
UMIP_INST_SIDT) {
>> +		u64 dummy_base_addr;
>> +		u16 dummy_limit =3D 0;
>> +
>> 		/* SGDT and SIDT do not use registers operands. */
>> 		if (X86_MODRM_MOD(insn->modrm.value) =3D=3D 3)
>> 			return -EINVAL;
>> @@ -228,13 +228,24 @@ static int emulate_umip_insn(struct insn *insn, =
int umip_inst,
>> 		else
>> 			dummy_base_addr =3D UMIP_DUMMY_IDT_BASE;
>>=20
>> -		*data_size =3D UMIP_GDT_IDT_LIMIT_SIZE + =
UMIP_GDT_IDT_BASE_SIZE;
>=20
> Maybe a blank line here?

Adding a blank line in place of the removed line? I=E2=80=99m not sure I =
see the need for it, there=E2=80=99s already a blank line above, and =
it's followed by the block comment.

Brendan=