Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Sep 2019 07:32:33 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <20190910062828.GA40888@gmail.com>
References: <20190905232222.14900-1-bshanks@codeweavers.com> <7BFFC7D1-6158-4237-AEF9-D10635F054FC@zytor.com> <20190910062828.GA40888@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] x86/umip: Add emulation for 64-bit processes
To:     Ingo Molnar <mingo@kernel.org>
CC:     Brendan Shanks <bshanks@codeweavers.com>,
        linux-kernel@vger.kernel.org,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "Eric W. Biederman" <ebiederm@xmission.com>
From:   hpa@zytor.com
Message-ID: <193CDEE9-B533-4BFE-972E-384C00359945@zytor.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On September 10, 2019 7:28:28 AM GMT+01:00, Ingo Molnar <mingo@kernel=2Eorg=
> wrote:
>
>* hpa@zytor=2Ecom <hpa@zytor=2Ecom> wrote:
>
>> I would strongly suggest that we change the term "emulation" to=20
>> "spoofing" for these instructions=2E We need to explain that we do
>*not*=20
>> execute these instructions the was the CPU would have, and unlike the
>
>> native instructions do not leak kernel information=2E
>
>Ok, I've edited the patch to add the 'spoofing' wording where=20
>appropriate, and I also made minor fixes such as consistently=20
>capitalizing instruction names=2E
>
>Can I also add your Reviewed-by tag?
>
>So the patch should show up in tip:x86/asm today-ish, and barring any=20
>complications is v5=2E4 material=2E
>
>Thanks,
>
>	Ingo

Yes, please do=2E

Reviewed-by: H=2E Peter Anvin (Intel) <hpa@zytor=2Ecom>
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E