Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp5535596ybe; Tue, 10 Sep 2019 05:23:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrw8s+PLMPVpvDU8WXe1SwoXeimqGdEXWbZhKMeEGVfzwzBfI2vL3ZsfC8Y4K8fMxfnX/D X-Received: by 2002:a17:906:aad2:: with SMTP id kt18mr24390918ejb.201.1568118201002; Tue, 10 Sep 2019 05:23:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568118200; cv=none; d=google.com; s=arc-20160816; b=cV75FRY+B2F8iOayirxvKfRlJOUGcUb97E8IdMyJgBn598KpV8ZNfxQtod/mOdUfRT GprjsOREtG4ciTGsSruQN8ocxJzsBJr7/ph+vhSsoE0MXfyp+UyxMwaAJq1MqBBVSmFI Ov5Hi47DhdSpmqa+VGHBYIH+qP2os4MMVn2pgLV8c//V+gttE12TYlJkQkVD/lfES0M3 /tI9kzu+lHhj5XaGxzQ8oI6UpLtQPnWnGGmFGGxaVSlKOTwkaY71gt0A6eCcIshxsmnu gqMebPK4ZpnsB5VtxrVrNvqXVE+4GdK7ZSHriPg0aMG1feVy+SqIAoCSWej7yUXjLl53 RocA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=sGqYubR5Lthr7yxzMgwTRpMO66aeWf2qCN8tGk0FHOg=; b=aNSZVjh603v9Dx0oqS0x8C0ZJYX5h0BezyD1uG3IMW9uKWZ/wXOPk8m6ZjmqmUta2X +5equMSXTVdklvnyko212gd2GVY1N/OXdqZteX8bUcyOHs8GdorGjz7UfhDBhYdYGye9 nLd3SU2fYv6MwQ1mPPRi7tpaYTqGfaDvLu+dGVnQf+jxKOKEYQOPMP4XUpbJKRRjG2eu ml1BZAis3ii9fsFuQdMXC8xMfjQKka/wyEP1gn8S7C8FKkzWST+dp6qdADQBVCwwTae0 jylcCpFfJPjvBlZTHcAw5HcN/fgbYmxSoxAHToVsiifIDGwhekM4c6WWkhQhY7j0i3oi U4fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=H9a4A105; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z55si10519950edz.254.2019.09.10.05.22.57; Tue, 10 Sep 2019 05:23:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=H9a4A105; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405520AbfIJKD1 (ORCPT + 99 others); Tue, 10 Sep 2019 06:03:27 -0400 Received: from mail-pg1-f202.google.com ([209.85.215.202]:41953 "EHLO mail-pg1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405501AbfIJKD0 (ORCPT ); Tue, 10 Sep 2019 06:03:26 -0400 Received: by mail-pg1-f202.google.com with SMTP id b18so10349229pgg.8 for ; Tue, 10 Sep 2019 03:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=sGqYubR5Lthr7yxzMgwTRpMO66aeWf2qCN8tGk0FHOg=; b=H9a4A105QMmIT8qtxtAQb/NY2MEr1GOUe/9IKXYp1yvFWHSfAlO7CBzcQZRfYWqncZ ZxjG2BQdBexz3OJ4rQ18i+Tdc3DAR0KN3k1p2m17MRcZgGQGgZz5/r8Hh6ucuKYTFsIi fkb8CbJOBYh5MchJNUxddQmx01y0IRBgwhn9w7/i/8qNC3CBTrlV1D1ve6Q/DDPIurib yxPmoPvNIBTWUXkW4bGU99MVYfLii9je1nMATSauAG/U7ocCXMNyfCM+zbtllmDkLzGg do7yLqBRV4AxHkpxALJqAc8OwbG2kROF+aQt44aAwQhK2tgyyCAquB/tOVTRHxvF3hM2 vuCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=sGqYubR5Lthr7yxzMgwTRpMO66aeWf2qCN8tGk0FHOg=; b=Mr2FiVoZCy00Vo/VDtYeSkNIg6kLG+Txqy3LNDhM5RazJZMIwKZRKUcj5sdaGLbbSl 5wABEPsZp/wFpyOFU1NePB2ZmOE1b1TadJXJkqnwX1mYoW659UEPDh9O+07i7WcFgyqi BOGnD1QYdE2jK5xfBXG8p9Mrr3tZYmuf5aYuNf1Qtr6iQQBlCsdrtlJiJHR6L7mQipS1 cRQRf0w1R+eUMbPfXyDld1AgrM04Ne2mlw/g+8my3AkJj3jzs/2et7K7PkZzRQZmeY+m 7cKMkfH1ca2cyeXOP+qrnWtAx3xhtZRcXEuOgJtvRf/CafoUrUZVekvZ8MNswgrq9tAd ImMA== X-Gm-Message-State: APjAAAUA1/DzWXO29AnZovozZPxalPqMWwiKfrUzQnuN1yInMOMe6wFj J9gvn3q9vaW2YzkS83NTCDym9in/zmYxpfSo6IecNQ== X-Received: by 2002:a65:6850:: with SMTP id q16mr27663278pgt.423.1568109805751; Tue, 10 Sep 2019 03:03:25 -0700 (PDT) Date: Tue, 10 Sep 2019 03:03:17 -0700 In-Reply-To: <20190910100318.204420-1-matthewgarrett@google.com> Message-Id: <20190910100318.204420-2-matthewgarrett@google.com> Mime-Version: 1.0 References: <20190910100318.204420-1-matthewgarrett@google.com> X-Mailer: git-send-email 2.23.0.162.g0b9fbb3734-goog Subject: [PATCH 1/2] security: constify some arrays in lockdown LSM From: Matthew Garrett To: jmorris@namei.org Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Matthew Garrett , Matthew Garrett , David Howells Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No reason for these not to be const. Signed-off-by: Matthew Garrett Suggested-by: David Howells --- security/lockdown/lockdown.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c index 0068cec77c05..8a10b43daf74 100644 --- a/security/lockdown/lockdown.c +++ b/security/lockdown/lockdown.c @@ -16,7 +16,7 @@ static enum lockdown_reason kernel_locked_down; -static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = { +static const char *const lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = { [LOCKDOWN_NONE] = "none", [LOCKDOWN_MODULE_SIGNATURE] = "unsigned module loading", [LOCKDOWN_DEV_MEM] = "/dev/mem,kmem,port", @@ -40,7 +40,7 @@ static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = { [LOCKDOWN_CONFIDENTIALITY_MAX] = "confidentiality", }; -static enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE, +static const enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE, LOCKDOWN_INTEGRITY_MAX, LOCKDOWN_CONFIDENTIALITY_MAX}; -- 2.23.0.162.g0b9fbb3734-goog