Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190909054219.GA119246@LGEARND20B15>
In-Reply-To: <20190909054219.GA119246@LGEARND20B15>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Tue, 10 Sep 2019 20:17:59 +0900
Message-ID: <CADLLry4CjS+1syBCf68BFUbWxZJ8UGcUphinE1Hs7FRvdK0ikg@mail.gmail.com>
Subject: Re: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement
To:     aacraid@microsemi.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello, Maintainers...
Would you please review this patch and share the feedback?

Thanks,
Austin Kim

2019=EB=85=84 9=EC=9B=94 9=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 2:42, Au=
stin Kim <austindh.kim@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> The type of 'chan' is u32 which contain non-negative value.
> So 'chan < 0' is statment is always false.
>
> Remove unnecessary comparison statement
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  drivers/scsi/dpt_i2o.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index abc74fd..df48ef5 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1120,7 +1120,7 @@ static struct adpt_device* adpt_find_device(adpt_hb=
a* pHba, u32 chan, u32 id, u6
>  {
>         struct adpt_device* d;
>
> -       if(chan < 0 || chan >=3D MAX_CHANNEL)
> +       if(chan >=3D MAX_CHANNEL)
>                 return NULL;
>
>         d =3D pHba->channel[chan].device[id];
> --
> 2.6.2
>