Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Sep 2019 08:44:52 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Felipe Balbi <felipe.balbi@linux.intel.com>
Cc:     Christopher S Hall <christopher.s.hall@intel.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs
Message-ID: <20190910154452.GB4016@localhost>
References: <20190909075940.12843-1-felipe.balbi@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190909075940.12843-1-felipe.balbi@linux.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote:

>  	case PTP_PEROUT_REQUEST:
> +	case PTP_PEROUT_REQUEST2:

...

> +		if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) ||
> +			req.perout.rsv[0] || req.perout.rsv[1] ||
> +			req.perout.rsv[2] || req.perout.rsv[3]) &&
> +			cmd == PTP_PEROUT_REQUEST2) {
> +			err = -EINVAL;
> +			break;

...

> +/*
> + * Bits of the ptp_perout_request.flags field:
> + */
> +#define PTP_PEROUT_VALID_FLAGS (~0)

I think you meant (0) here, or I am confused...

Thanks,
Richard