Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190903033019.GA149622@LGEARND20B15>
In-Reply-To: <20190903033019.GA149622@LGEARND20B15>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Wed, 11 Sep 2019 01:39:03 +0900
Message-ID: <CADLLry6vC_bPEq9VLhz3_EXrDPZP1XDFLocnT3zxYEcCaX0QYw@mail.gmail.com>
Subject: Re: [PATCH] btrfs: fix Wmaybe-uninitialized warning
To:     clm@fb.com, Josef Bacik <josef@toxicpanda.com>, dsterba@suse.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello, maintainers.

If you are available, please review this patch and share the feedback.

Thanks,
Austin Kim

2019=EB=85=84 9=EC=9B=94 3=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 12:30, A=
ustin Kim <austindh.kim@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> gcc throws warning message as below:
>
> =E2=80=98clone_src_i_size=E2=80=99 may be used uninitialized in this func=
tion
> [-Wmaybe-uninitialized]
>  #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) =3D=3D 0)
>                        ^
> fs/btrfs/send.c:5088:6: note: =E2=80=98clone_src_i_size=E2=80=99 was decl=
ared here
>  u64 clone_src_i_size;
>    ^
> The clone_src_i_size is only used as call-by-reference
> in a call to get_inode_info().
>
> Silence the warning by initializing clone_src_i_size to 0.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  fs/btrfs/send.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index f856d6c..197536b 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -5085,7 +5085,7 @@ static int clone_range(struct send_ctx *sctx,
>         struct btrfs_path *path;
>         struct btrfs_key key;
>         int ret;
> -       u64 clone_src_i_size;
> +       u64 clone_src_i_size =3D 0;
>
>         /*
>          * Prevent cloning from a zero offset with a length matching the =
sector
> --
> 2.6.2
>