Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp5990825ybe; Tue, 10 Sep 2019 11:50:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqyS/z90sZXt4EOntt+WG9RqeQ3/UbtC8S8hqd+0MmJi7/y+5bpcpz8OptZ3RROj7xjByRp1 X-Received: by 2002:a17:906:a414:: with SMTP id l20mr26577200ejz.211.1568141440899; Tue, 10 Sep 2019 11:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568141440; cv=none; d=google.com; s=arc-20160816; b=l+3oz8Sm8pf6rzL1EQ1AdrM7Tamk60zl/GXQDjBb6t7pFt8rDSU4QgSowIO35GUPIH sHumP/qPBjVhRnFL+O+EiPff9NTWG69Fn0mitrEkkJQsBGvSkT2mSMCS3Zniqadjv5rv w5uNwVXRhdlMEhv236f3LXjxs2KtCEhDWyTkdaUnjdI704agcnhjKF3HNDCgJ1xIB0Ma u3Rc2dJU+KyTZBmLER6axMFZt1l1z41EeJJ6I9eIr8ncDsk/dIDEsvRIYwPLY8iYQWd4 u8X6C1Xw2mj/rMGALGQlp43XpAMVzpmiVkH+8JzsL1/d1hGR5GzpXXJsFLyHO/kNHCkD hSzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=iLNIOXR57qSeM9HTSvTKoNhCzLHKPHM+BM4lGP5KvPk=; b=pKvqwekT19v6js8KhQyqXtxGxdoHW/vKpWa0Hxu/H+Xd8I9HHcDXqq2LO8A2mGEdoj /HscQuMyNiSBB4PDAZIF4kbvGg0ASYe8+PKobLV9YHTdxcDpePr50a00ng4n2f/mrl3H yJQ6E6P1yR2kujBiSdaqv83/LxXwjAcuSSYCROvZNeKa6/74+Jf4IDEfVFICmiNcG2Hq cVDQ0B1sjfoeXeKYHsGv8iWHVFNz6Hz6BvQIYAQ9k3I0wEkowzlDa7+EKRtjBBNJe6z6 mod0kTWh8JNYg3PtEJbXtF5TfXVs3QG90FD/HeOJ1xtPsJT2P/c/cOQCOX5OUr8gHr4e wPEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e50si11588649edb.177.2019.09.10.11.50.17; Tue, 10 Sep 2019 11:50:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404811AbfIJIJc (ORCPT + 99 others); Tue, 10 Sep 2019 04:09:32 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53050 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404739AbfIJIJb (ORCPT ); Tue, 10 Sep 2019 04:09:31 -0400 Received: from localhost (unknown [148.69.85.38]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4F5F8154A86C5; Tue, 10 Sep 2019 01:09:28 -0700 (PDT) Date: Tue, 10 Sep 2019 10:09:23 +0200 (CEST) Message-Id: <20190910.100923.398630420341862032.davem@davemloft.net> To: chunguo.feng@amlogic.com Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] tcp: fix tcp_disconnect() not clear tp->fastopen_rsk sometimes From: David Miller In-Reply-To: <20190906093429.930-1-chunguo.feng@amlogic.com> References: <20190906093429.930-1-chunguo.feng@amlogic.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Sep 2019 01:09:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: chunguo feng Date: Fri, 6 Sep 2019 17:34:29 +0800 > From: fengchunguo > > This patch avoids fastopen_rsk not be cleared every times, then occur > the below BUG_ON: > tcp_v4_destroy_sock > ->BUG_ON(tp->fastopen_rsk); > > When playback some videos from netwrok,used tcp_disconnect continually. ... > Signed-off-by: fengchunguo This still needs review.