Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6043508ybe; Tue, 10 Sep 2019 12:37:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxisvDdA8z+QUQgWNCFWxGOKAPDEq1AELLY1AlGSb8rxtdhjsamWWp9Jx21WydLfivBek3 X-Received: by 2002:a17:906:244c:: with SMTP id a12mr25982929ejb.288.1568144253224; Tue, 10 Sep 2019 12:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568144253; cv=none; d=google.com; s=arc-20160816; b=Z+0pv6lahxEQ0/5oJk8G8NcT4TEliYrItmcRdHBSa8TgKIbOcoq3relXs6+Ox4eYt3 VzZqzcUc71UqsUc2xItgqFKT4SA6MXXgkdhExVUvxWhCd5wfGLusXYlxWwNtVQTxr3iT 4/UEC9PMM5Yf6xNBiKqp/Mn1bH4rt0KozPtyYG0dyyvYR3I704NlkoZDH/+CGjdY79De LKbUGOtdtw8Agoldq95T+ATxnSYtLEFGyK9CQeX8QKrQ5Q5tguC2AXVakWvd69TNhYP6 laX222/r5i6Nfw4cicTalcYrO5P333hecUuvCyg8+GUm9pwHJc6tZbZevNFOotseOt4X SBDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=tjxNGJLyX19AQqhMICAaAGbwGhdaVJ8YEOzgZyyiKDg=; b=QDF8R8ozJ9XvtH2uqkzuQT8Y/63ijgmO7aYh2W4T2nrfhd6K6VgdBPUzQCvmIjg2k2 s97YyFU7Cylot8ceSRHxOTWH8hLRlCE00CyFTQatFVtsmFgoQvMrzT6plcWgGke7W3lE LVfCdWJWhV10aWOJqw370MruAq14n7pG3+zbhxoFNTcSlVK4r4LWOPsQznrTOjPCZljY 1bbf1KA8W4MgKPEhkxpVJ+n+z8hF1OfWycDHPHSEaXsfk9zrVcDTynoPnzF2F5x5Cynk Ei9h7jHt0PQoJR44i3TpQouWztaYffxglyBCN+63Tlr8JqsRwMuXEu162KTR8qd+WdZw II2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=T5jK5zOv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c52si12741942eda.132.2019.09.10.12.37.08; Tue, 10 Sep 2019 12:37:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=T5jK5zOv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfIJTFy (ORCPT + 99 others); Tue, 10 Sep 2019 15:05:54 -0400 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:55647 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfIJTFx (ORCPT ); Tue, 10 Sep 2019 15:05:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1568142352; x=1599678352; h=from:to:subject:date:message-id:in-reply-to:references: mime-version; bh=tjxNGJLyX19AQqhMICAaAGbwGhdaVJ8YEOzgZyyiKDg=; b=T5jK5zOvygYDV4+w3VtqcCOcq6s8u7EonWN9MdypBIyOjc2BV0pbQ9TO ZBUe+RK/dW7WoZPEX2re5fa1ZI9jRkugsxUSrzaUF/8ODd5P3WKsZGxTr yQ+qFsXMq5/UYHv3h0hV0QVstcB1d2gY7hzMEngzXwKWXfcnxX3se3BdN o=; X-IronPort-AV: E=Sophos;i="5.64,490,1559520000"; d="scan'208";a="750032858" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-4e24fd92.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 10 Sep 2019 19:05:50 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2b-4e24fd92.us-west-2.amazon.com (Postfix) with ESMTPS id 41C92A1C2C; Tue, 10 Sep 2019 19:05:49 +0000 (UTC) Received: from EX13D01EUB001.ant.amazon.com (10.43.166.194) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 10 Sep 2019 19:05:48 +0000 Received: from udc4a3e82dbc15a031435.hfa15.amazon.com (10.43.160.5) by EX13D01EUB001.ant.amazon.com (10.43.166.194) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 10 Sep 2019 19:05:41 +0000 From: Talel Shenhar To: , , , , , , , , , , , , , Subject: [PATCH v2 3/3] soc: amazon: al-pos: cast to u64 before left shifting Date: Tue, 10 Sep 2019 22:05:10 +0300 Message-ID: <1568142310-17622-4-git-send-email-talel@amazon.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1568142310-17622-1-git-send-email-talel@amazon.com> References: <1568142310-17622-1-git-send-email-talel@amazon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.160.5] X-ClientProxiedBy: EX13D03UWC002.ant.amazon.com (10.43.162.160) To EX13D01EUB001.ant.amazon.com (10.43.166.194) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix wrap around for pos errors on addresses above 32 bit. Reported-by: kbuild test robot Signed-off-by: Talel Shenhar --- drivers/soc/amazon/al_pos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/amazon/al_pos.c b/drivers/soc/amazon/al_pos.c index a865111..e95e1fc 100644 --- a/drivers/soc/amazon/al_pos.c +++ b/drivers/soc/amazon/al_pos.c @@ -49,7 +49,7 @@ static irqreturn_t al_pos_irq_handler(int irq, void *info) writel(0, pos->mmio_base + AL_POS_ERROR_LOG_1); addr = FIELD_GET(AL_POS_ERROR_LOG_0_ADDR_LOW, log0); - addr |= (FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1) << 32); + addr |= (((u64)FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1)) << 32); request_id = FIELD_GET(AL_POS_ERROR_LOG_1_REQUEST_ID, log1); bresp = FIELD_GET(AL_POS_ERROR_LOG_1_BRESP, log1); -- 2.7.4