Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp302578ybe; Tue, 10 Sep 2019 19:17:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfRyMYXonbSvPJapW3cptNZeYs24NMVh/tTDLxjs+rpKXmA+RSeYOzWXxky5YbttkQanvk X-Received: by 2002:a05:6402:1e7:: with SMTP id i7mr35257718edy.103.1568168225298; Tue, 10 Sep 2019 19:17:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568168225; cv=none; d=google.com; s=arc-20160816; b=kaSE1jaA9buuypIgyqRzwtM3c3lj/D/CKDhMH8fKHPhCxqokA5mWHBpIWqH/H6w4XG zwrrT9AoYd3qI8DGRkMEV/Rr5GG9Z/4mKVE+IZaz8BYaoI1CB7mWQojrlKUR7ghuWyoF HXOeF33HrpScnKZmWgnuqJdrRnnhnOXx+rZ30PDS68TJ8Qk89xcdjwGgTLmhqlkwDroN ng5Y4vPg7mbvKw2OMJFs+l5y938w0loAo/C9L0NduuiXas3F2oWewtIefc/d34AZPUC1 8L+7hmH1ZRDPBwQFNS4J01OvNPd7K7GlNN/oU9NE7pjkxW+5izAyQ2IkS57wARw+VcPO IvyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=tYlswYMGfc9rDFq0KLhl5hLmx6KYuv+guMDS5/fpoEM=; b=P90ule7eFV2Schz//6fmmdMGEzBFmYUphV8lNUX8/gNsuA6MISAf83az75VkyJkKJX i/YLOLUILYYhJToGAzuFYCrimGFY0VCoJX3O0iDNMVhbW6xFwnRoslBWNKixKNfsULuO 1YzpJieAHBhQ6k1HMwwjHMm/8h+ydC8c6x6i+t/k2Yx6fDMQeEdQM5jPndfnIDNOOgr3 9xBLWz9jY850oZfA/T1/53gZlQqcI4elEIKT6yA/T26dcejirzsHpf1wLf6olqpfCbar ywKRJcoEgy+W+2zlTdWl527XebP6tLRzJdWXtUtgIl1OmwtEVPvVA3VVda8fz0v8sbtg uGqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Js7LEog6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si5608171edv.246.2019.09.10.19.16.40; Tue, 10 Sep 2019 19:17:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Js7LEog6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfIKCOw (ORCPT + 99 others); Tue, 10 Sep 2019 22:14:52 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51262 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbfIKCOv (ORCPT ); Tue, 10 Sep 2019 22:14:51 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8B2EMOe182060; Wed, 11 Sep 2019 02:14:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=tYlswYMGfc9rDFq0KLhl5hLmx6KYuv+guMDS5/fpoEM=; b=Js7LEog6OC6M0+Kt81FP53drVJPYFhEbEt1MjWP2AC4EIj/6hLxavD/qeZDeZaY1uAvE pg+bF0Yi1KEnm/Z1fs4PtIglkdLmTkNmZBVIWA/I8LBcW1KF6OnKDxSP267bDVczZSfY Dde4aVbD0BHlmXBPXnGh5IBHrt1h2rChQZIQfFdYc59hTGAPJLYVUqiMp02kYDa5byTx tLYgEBAWPQUC2EGvFvBC2eSb5b3wdwLPHUdy9Ksuqr4tLeudZxDD5trYiNiniCZ5AAyG 8WfBK9v90pVF0xBWuVPhTXz4Eh2i3qmx4SEL8tbHgLJ5FtTNJubs1a69KUpzsf/P9aYe 5A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2uw1m8xyrf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Sep 2019 02:14:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8B2DY7L114730; Wed, 11 Sep 2019 02:14:18 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2uxj3hw7yt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Sep 2019 02:14:18 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x8B2EF4i026967; Wed, 11 Sep 2019 02:14:15 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Sep 2019 19:14:15 -0700 To: Matt Lupfer Cc: "mst\@redhat.com" , "jasowang\@redhat.com" , "pbonzini\@redhat.com" , "stefanha\@redhat.com" , "jejb\@linux.ibm.com" , "martin.petersen\@oracle.com" , "virtualization\@lists.linux-foundation.org" , "linux-scsi\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190905181903.29756-1-mlupfer@ddn.com> Date: Tue, 10 Sep 2019 22:14:12 -0400 In-Reply-To: <20190905181903.29756-1-mlupfer@ddn.com> (Matt Lupfer's message of "Thu, 5 Sep 2019 18:19:28 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9376 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=997 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909110016 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9376 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909110016 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matt, > The event handler calls scsi_scan_host() when events are missed, which > will hotplug new LUNs. However, this function won't remove any > unplugged LUNs. The result is that hotunplug doesn't work properly > when the number of unplugged LUNs exceeds the event queue size > (currently 8). > > Scan existing LUNs when events are missed to check if they are still > present. If not, remove them. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering