Date: Sun, 25 Dec 2005 22:14:14 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Jaco Kroon <jaco@kroon.co.za>
Cc: davej@codemonkey.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ati-agp suspend/resume support
Message-ID: <20051225211414.GA1943@elf.ucw.cz>
References: <43AF0122.9030904@kroon.co.za>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43AF0122.9030904@kroon.co.za>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1318
Lines: 49

Hi!

> Based on the patch at
> http://unixhead.org/docs/thinkpad/ati-agp/ati-agp.diff, add support for
> suspend/resume in the ati-agp module.
> 
> Signed-of-by: Jaco Kroon <jaco@kroon.co.za>
> 
> --- linux-2.6.15-rc6/drivers/char/agp/ati-agp.c.orig	2005-12-25
> 22:21:32.000000000 +0200
> +++ linux-2.6.15-rc6/drivers/char/agp/ati-agp.c	2005-12-25
> 22:23:33.000000000 +0200
> @@ -243,6 +243,15 @@
>  	return 0;
>  }
> 
> +static int ati_resume(struct pci_dev *dev)
> +{
> +	return ati_configure();
> +}
> +
> +static int ati_suspend(struct pci_dev *dev, pm_message_t state)
> +{
> +	return 0;
> +}

I think you can just leave out empty function; that should work,
too. Otherwise it looks good, thanks... ...

>  /*
>   *Since we don't need contigious memory we just try
> @@ -525,6 +534,8 @@
>  	.id_table	= agp_ati_pci_table,
>  	.probe		= agp_ati_probe,
>  	.remove		= agp_ati_remove,
> +	.resume		= ati_resume,
> +	.suspend	= ati_suspend,
>  };

...aha, plus you may want to keep naming convention. It should
probably be agp_ati_resume.
							Pavel
-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/