Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp532613ybe; Wed, 11 Sep 2019 00:19:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyrJdNi3x9UrLJ8ZFEeQEyEQ0sf4DdgRDksRzfjmyD2yTrLolAxYpGVO9tZ35Qeg5EdsPKr X-Received: by 2002:a50:de8f:: with SMTP id c15mr35359472edl.47.1568186342824; Wed, 11 Sep 2019 00:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568186342; cv=none; d=google.com; s=arc-20160816; b=mNSJGyRzsAA7kuIw5FNrIm4aXe7oFQqosG7uIuVwPUzETl83nmCFnfu7ro64dLiF9K VMo/V/7XQqN5fPVKuKKE/e0iU+RZwSzG4s8yE1N4SLk2j6ugBWXru+UCnyqtMJm0nD7U CUEbd/69rnh2rYYTOzhUu5cj3z6pJq15jHYEIR3D0Ajyqj7Y8TaB5pb9DDu5PRVd6DFc j2MNxzaDOsaIwQMhamna8uQDzYwBrYf3jzMGUfSr5C5SN1VEsQlFyr5V5XiU5le4kYg8 a13HK7S43gABPndzvs2HsKQG2MvkseYCAALaigmgd0YiK+HTUpQ5YAV4oUh4hI/Vuxjc CBiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=BcKGfqptsJMIyqg8m+kdv7mwKKvvYfua8/fbCWYYrS8=; b=Mx3HsTQsOP3OfwR5a+ILRwc9j9MQDLUeWPLFOdtLMs7FvK/pLUNSY2ZuSVQzs85br9 Sh7+78cVq/6VmL4Cv3wKvIfyqllSevYLJje2z/i4TgSb2/UWw2FlbMGQZn0wd/j5aWm+ PD8wXCLrPmW3X4ST+00XDrn+6INqZLD+gz0yDyoy64eBkmBxrCmY4W6roUctMJ1hNkqL g9D1gFDQXN+8plZnASgD2MK2WzvCCVA04LYp7MiSKUfE7/FU7mgIjG2qtNRSjZNOKmS2 Zq3mI4qktO8u69T/9rvv28HM2PmK1gxFi6JGi334ZXi/9lUnRj3+m0ldua+XqHZ4EF9G hGng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="o7pSB/lB"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si10494198ejd.71.2019.09.11.00.18.38; Wed, 11 Sep 2019 00:19:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="o7pSB/lB"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727023AbfIKHQt (ORCPT + 99 others); Wed, 11 Sep 2019 03:16:49 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39732 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbfIKHQs (ORCPT ); Wed, 11 Sep 2019 03:16:48 -0400 Received: by mail-pg1-f195.google.com with SMTP id u17so11054023pgi.6 for ; Wed, 11 Sep 2019 00:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=BcKGfqptsJMIyqg8m+kdv7mwKKvvYfua8/fbCWYYrS8=; b=o7pSB/lBJepCsIAK9wwEl+41gBqxhzj1JE5Xk93Xw+PiLLGCJiaRXIgX89oRURyZnw l3RtJSgM55DVzGJjWn4+MDNVoP63T55tIwc6Q5UURuq4/Y3FFS5V23mHe1sVX1K7hWed oQ2vD5nDD4cKYHQMqs1ShVZ7s1ZcieLRdx12COreB9e9vazjIAfQH0qkMOxgbAvMis7H /3XEpCvRHuhZx7j6J3FmzwjCMwDqLMzZd/sIa4LxZhl+TIQWHZbDva4KqVoad2s5xT7S x0eDDX5jO85RYBiiXqBTADEBhZwbO15EZfMLKNsiNqF+bExaugY7uXjyl2+5UEzDL894 EKzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=BcKGfqptsJMIyqg8m+kdv7mwKKvvYfua8/fbCWYYrS8=; b=pBlDbLDyIAl8yHWWMe3SsCPaX5c11kujE4iCYKaLC2dZMszM412sFYYZca16CBamaZ ZuFitGp74A1zwbxSEahoepw/HX/WxY5nN3ceVyEz2AKncvrkr9V89q5U8P20HG/MLPYb ThNLKZOtfJLtWa1knauiT+9ikouKEnoWiMJi2M/dmR0X3ELGyNRQFKFx9GcarTwf5/Hg nJvVpboJbct/+jz5jmEiYOb7q09bVc6BEtuh6w0yksh8+qjOfC8LpL05BKkaSOnruGTZ xQ6ZwMHVqrRnZMMLQv//AeoXhAfRMqyJ+FQP4TiobZ8HqKQDScXoZlwa1xkDrDsatyq4 FY4Q== X-Gm-Message-State: APjAAAXE/A4mYpK1+22QmkmMLWs7lZ+dc5+CUnRe08Sjg+f5G9fjbdNm ToH/HBSyQ96f0KhEbuYOMLz+mP+NGAG6rg== X-Received: by 2002:a62:e508:: with SMTP id n8mr20353567pff.199.1568186207721; Wed, 11 Sep 2019 00:16:47 -0700 (PDT) Received: from localhost ([49.248.201.118]) by smtp.gmail.com with ESMTPSA id 20sm24094678pfh.72.2019.09.11.00.16.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Sep 2019 00:16:47 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org, Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v3 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Date: Wed, 11 Sep 2019 12:46:19 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move platform_set_drvdata up to avoid an extra 'if (ret)' check after the call to tsens_register. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 6ed687a6e53c..542a7f8c3d96 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -149,6 +149,8 @@ static int tsens_probe(struct platform_device *pdev) priv->feat = data->feat; priv->fields = data->fields; + platform_set_drvdata(pdev, priv); + if (!priv->ops || !priv->ops->init || !priv->ops->get_temp) return -EINVAL; @@ -167,11 +169,7 @@ static int tsens_probe(struct platform_device *pdev) } } - ret = tsens_register(priv); - - platform_set_drvdata(pdev, priv); - - return ret; + return tsens_register(priv); } static int tsens_remove(struct platform_device *pdev) -- 2.17.1