Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp662369ybe; Wed, 11 Sep 2019 02:45:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8jHCd1/mkXYh64PFuFl0ZS6Tl/HEWd3QwBGhJXM+F4jA+PvvJN1kkWLx2w6D9tm2hUzHB X-Received: by 2002:a17:906:3b8a:: with SMTP id u10mr29623298ejf.167.1568195128464; Wed, 11 Sep 2019 02:45:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568195128; cv=none; d=google.com; s=arc-20160816; b=Pmw/xyz0qIuJgDwIIkJ2J7pl9w92RNLTtDZbXcrVVd8R9dQuVnsyeM3T8MR1hzijNB 3YuoHkMjATwvxXdBXMLbcCfV5mRKEb+zcOfcax1KPxifiOq0snv6T2UEf/9cVfGL4apc DD+oVtU7r8Urc1HnkDCgrvxz9F1R0mDCkz6Klp1hVwlVYsZMmP6O7PdjKSU6pAzS+a3c p11QWQCTMDMgS8kyZ1ytoQSzgEYgA0pNX6Zr7MxaZlFf7+8UlJtED+AEd1oaBHlUI83b OceZqehb8ywnAU4dmejJGImy6XpKNKfURtlwChD0Z6DO9Sc2S0LuC+LmM/EPiU11ywnE 3P7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=n0eGU7EwYvV44i/yZMlYO2mgsRqBSzpFil4+yiEnP3M=; b=iJyWX+Nd4TYlDjlRHEgJEBDy1cKhceorEAn1T6OjN8KoQB2YYat1JU+lCmpk26hOLW Dg07ntkJ6GSjTzMk7D1HGhFtPLrKf29u2cHELIJ9xXSqDefzAL1XhvGgmNRhr1Tmxc+6 llH3y5EV6Eawrst77sARRD7MAd0vJhfGP5UwKjbymQkfi8WAueC+B5JqVkA6LZv21IkO Uq9pfNOmsJhLcJQFU42Y2AqoQrdlynKZXGJmCAleLjWmXpXx2yiWky+wGeg9uRralch9 QR/d+cWPIo/Nl97lRm0pkLdlzlWrBSr8CQzGEKjQYuMLQopJwmX+DSrQPj9iK1gCQMZJ VXhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jcbRuqnq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k55si13630026edd.179.2019.09.11.02.45.04; Wed, 11 Sep 2019 02:45:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jcbRuqnq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727302AbfIKJnK (ORCPT + 99 others); Wed, 11 Sep 2019 05:43:10 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:35682 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726724AbfIKJnK (ORCPT ); Wed, 11 Sep 2019 05:43:10 -0400 Received: by mail-lf1-f68.google.com with SMTP id w6so15945032lfl.2 for ; Wed, 11 Sep 2019 02:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n0eGU7EwYvV44i/yZMlYO2mgsRqBSzpFil4+yiEnP3M=; b=jcbRuqnqmVkgtZ98MPCNgpOW1Z6kmUSw8xfMYAW37/xJ62Qt3QsQ/voTaoFkiTXyDP w1Q6d7XhKj2eklW4V5AoidRHlrApe860OCk56LBhG/GrCi+4h+4CGPvYYXbc21mT2Qmb n8/oZluaIZNJqeg71T5o1EhMoB+m0tTvFGbJeLBixpk1B0OvuwGsdc44VhKJIB54ydLM +rJ1kHOtRpY3wWwCnkSYJO6TzxUPRlzQadSIu3Q0h8wveQneMW03LB1cnaSuhiyk35Up nJFTKiaBIgKKwiKSXI8tF9Js1bVU4DuCKFCf6MOBC8EWum5/LM9CClP0N5EetYarRvQn HOcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n0eGU7EwYvV44i/yZMlYO2mgsRqBSzpFil4+yiEnP3M=; b=Thiql6ceJA+NnrneWx3eq7m6mIATG4CnChoQ5bziSpVYOPus4gu1XNptPK0X4qhd+E VH37R/n/JIu+FXimVMfZP8euW0444Y8uF5436h5ozZqhBEpbVxybswFI65Rj3WUDp/Cg Ydn1CuvL9XI/tveKThBy0bIsiSGphOl1acKxKz80Gm94Q8Ef6rN6wRCqZ1YXrT3UYN/x eB26Es0a6EqzZzD6xvEUuuYifG863wgyzOTCH5GqSm8VySXGGwb/3WzzJlVoBKEGZzSX C0Jhz/QU09g6esS134wwR+97VLLDUZp1Y3oXt/1Z3tX0/W3FN6J7c7bEJcYW+jOPb5b/ vKRw== X-Gm-Message-State: APjAAAVd5mzrS8mrGwVfKNkyPsDyX9VnqYSd5LMUnE2/fCMBZkom4RO5 +G0LAqYKvHFS5Aan9sMVdbSXJCTUQPFvGMFW63faaw== X-Received: by 2002:ac2:51a7:: with SMTP id f7mr1200184lfk.152.1568194988428; Wed, 11 Sep 2019 02:43:08 -0700 (PDT) MIME-Version: 1.0 References: <1567054348-19685-1-git-send-email-srinath.mannam@broadcom.com> <1567054348-19685-3-git-send-email-srinath.mannam@broadcom.com> In-Reply-To: <1567054348-19685-3-git-send-email-srinath.mannam@broadcom.com> From: Linus Walleij Date: Wed, 11 Sep 2019 10:42:57 +0100 Message-ID: Subject: Re: [PATCH 2/2] gpio: iproc-gpio: Handle interrupts for multiple instances To: Srinath Mannam Cc: Ray Jui , Scott Branden , bcm-kernel-feedback-list , Linux ARM , "linux-kernel@vger.kernel.org" , Rayagonda Kokatanur Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 5:52 AM Srinath Mannam wrote: > From: Rayagonda Kokatanur > > When multiple instance of iproc-gpio chips are present, a fix up > message[1] is printed during the probe of second and later instances. > > This issue is because driver sharing same irq_chip data structure > among multiple instances of driver. > > Fix this by allocating irq_chip data structure per instance of > iproc-gpio. > > [1] fix up message addressed by this patch > [ 7.862208] gpio gpiochip2: (689d0000.gpio): detected irqchip that > is shared with multiple gpiochips: please fix the driver. > > Fixes: 616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc") > Signed-off-by: Rayagonda Kokatanur Patch applied, I had to rewrite it a bit to fit the new code that set up the irqchip when adding the gpio_chip, please check that the result works. Yours, Linus Walleij